Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

miscellaneous fixes #828

Merged
merged 3 commits into from
Feb 21, 2018
Merged

miscellaneous fixes #828

merged 3 commits into from
Feb 21, 2018

Conversation

BurntSushi
Copy link
Owner

This PR fixes a few miscellaneous bugs: #789 (omit revision in version string when unavailable), #791 (add man page to ARM build) and #815 (clarify ripgrep failure mode in user guide).

This adds a hint for end users that run into a common failure mode where
ripgrep won't search any files because they have a `*` rule in their
`$HOME/.gitignore`.

Fixes #815
If the revision is empty, then we shouldn't show the `(rev )` text in
the output of `rg --version`.

Fixes #789
This fixes a bug where ripgrep's man page wasn't generated in the ARM
cross-compile build. Mostly, this should just require installing
asciidoc and making sure we test that it actually works.

Fixes #791
@BurntSushi BurntSushi merged commit cb47be9 into master Feb 21, 2018
@BurntSushi BurntSushi deleted the ag/misc-fixes branch February 21, 2018 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant