Use cwd to resolve paths in Ignore::matched #962
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes BurntSushi#829 and BurntSushi#278. This does change the Ignore struct to depend on the working directory at the time of creation, I _think_ this is fine, since Ignore isn't publicly accessible and the Walk structs already depend on the current working directory implicitly. I tried to make a minimal change to fix the issue. An alternative implementation could be to call `current_dir` in the `matched_ignore` method instead of in `add_parents`, but I'm not sure of the performance implications of doing that. Another possible solution would be to change the places that we call `Ignore::matched` to change the path to be relative to the absolute_base of the `Ignore`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #829 and #278.
This does change the Ignore struct to depend on the working directory at
the time of creation, I think this is fine, since Ignore isn't
publicly accessible and the Walk structs already depend on the current
working directory implicitly.
I tried to make a minimal change to fix the issue. An alternative
implementation could be to call
current_dirin thematched_ignoremethod instead of in
add_parents, but I'm not sure of the performanceimplications of doing that.
Another possible solution would be to change the places that we call
Ignore::matchedto change the path to be relative to the absolute_baseof the
Ignore.