Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
This PR adds initial support for serde. One of the cool things about it is that it can directly deserialize into a structure instead of having to go through
cbor::Decoder
to parse out aCbor
type and then deserialize from that into acbor::RustcDecoder
. It currently passes the tests and benchmarks pretty well (although it's still slower than serde_json for some unknown reason):Along the way I also changed how variants are serialized. Instead of
{"variant": "Name", "fields": [...]}
, it's now{"Name": [...]}
. This is much more efficient for serde to parse because it doesn't require potentially buffering the field argument.Be aware though that this does add a testing dependency to
serde_macros
, which is currently nightly-only. Check out howserde_tests
in https://githb.com/serde-rs/serde if you're interested in a method that's compatible with stable rust.