Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix panic in FrameDecoder #30

Merged
merged 1 commit into from
Jul 6, 2020
Merged

Fix panic in FrameDecoder #30

merged 1 commit into from
Jul 6, 2020

Conversation

pawanjay176
Copy link
Contributor

Fixes #29

Returns an UnsupportedChunkLength error if len < 4 as suggested.

Also modifies the docs on the UnsupportedChunkLength error variant to be more generic.

@pawanjay176
Copy link
Contributor Author

Hey @BurntSushi, keen to get this merged. Please let me know if I need to make any changes.
Thanks again :)

BurntSushi
BurntSushi approved these changes Jul 6, 2020
View reviewed changes
Copy link
Owner

@BurntSushi BurntSushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@BurntSushi BurntSushi merged commit 0afa07f into BurntSushi:master Jul 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BurntSushi BurntSushi BurntSushi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FrameDecoder panics on malformed input
2 participants
@pawanjay176 @BurntSushi