Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing file emoji-data.txt #9

Closed
mattias-p opened this issue Mar 7, 2019 · 0 comments
Closed

Missing file emoji-data.txt #9

mattias-p opened this issue Mar 7, 2019 · 0 comments
Labels
bug Something isn't working

Comments

@mattias-p
Copy link

I ran into this following the instructions in the Example section on the crates.io page:

$ ucd-generate property-bool /tmp/ucd-10.0.0 --include Hyphen,Dash,Quotation_Mark --chars
No such file or directory (os error 2)

I had to dig into the code to figure out what was going on. The missing file is emoji-data.txt.

I reproduced this behavior with both version 0.2.1 (cargo install) and current master (b56d7f3).

I would have expected:

  1. The instruction on crates.io to not run into file-not-found errors. Maybe a first example that doesn't require emoji-data.txt?
  2. A more discoverable instruction for downloading emoji-data.txt. Maybe an adapted version of the note in emoji_properties.rs in the Example section, along with some hints for when it's needed and which version to pick?
  3. Path-related error messages to spell out the troublesome path. Maybe relative to <ucd-dir>?

If you like I could make a PR to spell out the relevant path in error messages?
@BurntSushi BurntSushi mentioned this issue Jul 21, 2019
Closed
@BurntSushi BurntSushi added the bug Something isn't working label Jul 21, 2019
dingelish pushed a commit to mesalock-linux/ucd-generate-sgx that referenced this issue Aug 7, 2019
@BurntSushi @dingelish
errors: improve failure modes when emoji-data.txt is missing
ece450a 
This commit improves the overall failure modes when I/O errors occur
while reading UCD data. In particular, the emoji-data.txt file is not
parse of the main UCD download, so we permit reading it to fail if it's
an I/O error.

Error messages should now include file paths.

Fixes BurntSushi#9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@BurntSushi @mattias-p