Fix Issue #21: automatic calculation of alignment padding after lists #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wonderful! I'm happy to have this alignment stuff finally sorted out. Thank you very much! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed xgbgen so that it puts alignment padding between lists so that the first element of every list is aligned to 4 bytes (if the size of the list element is more than 4 bytes) or to the size of the list's element struct.
This doesn't make any sense to me but it seems to be what xcb c_client.py does. Tests and examples work on my machine.
Requests are padded to 4 bytes, always.
I also added a test case for Issue #12.