-
-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Autotag is broken: stable branch needs to use at least node14 instead of node13 #45
Comments
undici pushed a new update that broke autotag - it now is basically the same error (usage of optional chaining) just from a different script. |
Correct, this action is broken here as well. |
Workaround for now is to use |
Is it worth pinging the author on this? I've actually been relying on this |
Same here 🥲 |
Workaround for ButlerLogic/action-autotag#45
* Update prod-build.yml Workaround for ButlerLogic/action-autotag#45 * initial stripe changes * order by descending subscription end date to get the latest entry * fix github action for artifact registry * fix invite link * patch release * fix patch version --------- Co-authored-by: Greg Lind <greg@buildly.io> Co-authored-by: Radhika Patel <radhika.patel2206@gmail.com>
* Update prod-build.yml Workaround for ButlerLogic/action-autotag#45 * initial stripe changes * order by descending subscription end date to get the latest entry * fix github action for artifact registry * fix invite link * patch release * fix patch version * patch version --------- Co-authored-by: Greg Lind <greg@buildly.io> Co-authored-by: Peter Odeny <odenypeter@gmail.com>
* Update prod-build.yml Workaround for ButlerLogic/action-autotag#45 * initial stripe changes * order by descending subscription end date to get the latest entry * fix github action for artifact registry * fix invite link * patch release * fix patch version * patch version * cancel subscriptions * implement subscription cancellation * change insights to labs --------- Co-authored-by: Greg Lind <greg@buildly.io> Co-authored-by: Peter Odeny <odenypeter@gmail.com>
* Update prod-build.yml Workaround for ButlerLogic/action-autotag#45 * initial stripe changes * order by descending subscription end date to get the latest entry * fix github action for artifact registry * fix invite link * patch release * fix patch version * patch version * cancel subscriptions * implement subscription cancellation * change insights to labs * fix unit test github action * patch version --------- Co-authored-by: Greg Lind <greg@buildly.io> Co-authored-by: Peter Odeny <odenypeter@gmail.com>
Issue:
butlerlogic/action-autotag@stable uses node13 but also makes use of the most recent version of other libraries (notably https://github.com/nodejs/undici) which need >= node14.
This leads to the following warnings when building:
So far this has not caused problems.
But in version v5.27.1 of undici they started using optional chaining (which is only supported in >= node14).Luckily because of their incredible response time (and me missing that the issue was actually caused by autotag and not their library) they worked around the issue in version v5.27.2 before I could close the issue again. But you might update the stable branch to at least node14 to get rid of the warnings when building and in case optional chaining (or other features) is introduced again in any other library.
The problem resurfaced again in version v5.28.0 which means autotag is now broken again.
The problem is explained in more detail here (it is focused on version v5.27.1 which they changed afterwards. but exactly the same problem was introduced again in v5.28.0,):
nodejs/undici#2399
How To Reproduce:
Just build action-autotag@stable and notice the warnings.
Expected Behavior:
Either not use the most recent versions of other libraries or update nodeJS to version 14 or above.
Full terminal output (notice warnings in
#9
)The text was updated successfully, but these errors were encountered: