Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update Node version to LTS v22 #21

Merged
merged 7 commits into from
Jan 16, 2025

Conversation

martinalbert
Copy link
Contributor

@martinalbert martinalbert commented Jan 10, 2025

This PR updates and sets the minimal required Node version to LTS, more specifically to version 22.10.5.

Due to Node update, Angular version needed to be migrated to v18 due to its possible compatibility issues. Version compatibility of Angular to Node and RxJS can be seen here: https://angular.dev/reference/versions.

With Angular update, we also remove polyfill file and use the zone.js in configuration file delegating this responsibility to Angular.

Copy link

vercel bot commented Jan 10, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
angular-starter-buttercms ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 15, 2025 5:13pm

@ViolanteCodes
Copy link
Collaborator

@martinalbert I see two moderate severity security vulnerabilities - but it looks like the buttercms-js is still 1.2.5 (most current is 3.0.0) - are we planning on updating this separately with the starter project updates? (e.g., are we splitting into two separate jobs to reduce scope, this one being the node update and the other one being updating starter to most recent architecture?)

@martinalbert
Copy link
Contributor Author

@ViolanteCodes, I updated the buttercms-js to v3 after successful testing. Security vulnerabilities should be removed.

Copy link
Collaborator

@ViolanteCodes ViolanteCodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - no vulnerabilities on fresh install, all content is complete

@ViolanteCodes ViolanteCodes merged commit f36bfef into main Jan 16, 2025
2 checks passed
@ViolanteCodes ViolanteCodes deleted the feature/update-node-version branch January 16, 2025 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants