Merge pull request #6 from benyucong/cp_internal

fix: Fix stack buffer overflow issue when calling copy_to_cstr
ByConity · Jul 21, 2023 · 53eb5c0 · 53eb5c0
2 parents c83d7d7 + e95c05f
commit 53eb5c0
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/src/brpc/input_messenger.cpp b/src/brpc/input_messenger.cpp
@@ -94,7 +94,8 @@ ParseResult InputMessenger::CutInputMessage(
                 return result;
             } else {
                 if (m->_read_buf.size() >= 4) {
-                    char data[PROTO_DUMMY_LEN];
+                    // `data' must be PROTO_DUMMY_LEN + 1 to store extra ending char '\0'
+                    char data[PROTO_DUMMY_LEN + 1];
                     m->_read_buf.copy_to_cstr(data, PROTO_DUMMY_LEN);
                     if (strncmp(data, "RDMA", PROTO_DUMMY_LEN) == 0 &&
                         m->_rdma_state == Socket::RDMA_OFF) {