Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DRAFT]Migrate frontend configs to ESlint 9 #61

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

[DRAFT]Migrate frontend configs to ESlint 9 #61

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
23224ea
feat: migrate frontend configs to flat for ESlint 9
mltsk Jan 21, 2025
d79fd12
feat: update config
mltsk Jan 22, 2025
9c13d64
fix: fix path
mltsk Jan 22, 2025
95fae7c
feat: add rule
mltsk Jan 22, 2025
d7b1943
fix: todo
mltsk Jan 24, 2025
1ac8121
chore: bump eslint to 9.19.0
mltsk Jan 27, 2025
67a93ab
feat: add import/order
mltsk Jan 27, 2025
f67df84
feat: naming for boolean var
mltsk Jan 27, 2025
e902fcb
fix: rule complexity
mltsk Jan 27, 2025
4a8f5db
fix: rule no-use-before-define
mltsk Jan 27, 2025
f6f30f7
chore: bump version to 4.0.0
mltsk Jan 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
136 changes: 69 additions & 67 deletions configs/best-practices.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,69 +1,71 @@
/* https://eslint.org/docs/rules/#best-practices */
module.exports = {
rules: {
'array-callback-return': 'error',
'block-scoped-var': 'error',
'class-methods-use-this': 'warn',
complexity: 'warn', // TODO
'consistent-return': 'error',
curly: ['error', 'multi-line'],
'default-case': 'error',
'default-case-last': 'warn',
'default-param-last': 'warn',
'dot-location': ['error', 'property'],
'dot-notation': 'warn',
eqeqeq: 'error',
'guard-for-in': 'error',
'max-classes-per-file': 'warn',
'no-caller': 'error',
'no-constructor-return': 'error',
'no-div-regex': 'warn',
'no-else-return': 'warn',
'no-eq-null': 'error',
'no-eval': 'error',
'no-extend-native': 'error',
'no-extra-label': 'error',
'no-floating-decimal': 'error',
'no-implicit-coercion': [
'error',
{
boolean: false
}
],
'no-implied-eval': 'error',
'no-invalid-this': 'error',
'no-iterator': 'error',
'no-labels': 'error',
'no-lone-blocks': 'error',
'no-loop-func': 'error',
'no-multi-spaces': 'warn',
'no-new-func': 'error',
'no-new-wrappers': 'error',
'no-param-reassign': 'error',
'no-proto': 'error',
'no-return-assign': 'error',
'no-return-await': 'error',
'no-script-url': 'error',
'no-self-compare': 'error',
'no-sequences': 'error',
'no-throw-literal': 'error',
'no-unused-expressions': 'error',
'no-useless-call': 'error',
'no-useless-concat': 'error',
'no-useless-return': 'error',
'no-void': 'error',
'no-with': 'error',
'prefer-named-capture-group': 'warn',
'prefer-regex-literals': 'warn',
radix: 'error',
'require-await': 'error',
'wrap-iife': ['error', 'inside'],
yoda: [
'warn',
'never',
{
exceptRange: true
}
]
export default [
{
rules: {
'array-callback-return': 'error',
'block-scoped-var': 'error',
'class-methods-use-this': 'warn',
complexity: ['warn', { max: 20 }],
'consistent-return': 'error',
curly: ['error', 'multi-line'],
'default-case': 'error',
'default-case-last': 'warn',
'default-param-last': 'warn',
'dot-location': ['error', 'property'],
'dot-notation': 'warn',
eqeqeq: 'error',
'guard-for-in': 'error',
'max-classes-per-file': 'warn',
'no-caller': 'error',
'no-constructor-return': 'error',
'no-div-regex': 'warn',
'no-else-return': 'warn',
'no-eq-null': 'error',
'no-eval': 'error',
'no-extend-native': 'error',
'no-extra-label': 'error',
'no-floating-decimal': 'error',
'no-implicit-coercion': [
'error',
{
boolean: false
}
],
'no-implied-eval': 'error',
'no-invalid-this': 'error',
'no-iterator': 'error',
'no-labels': 'error',
'no-lone-blocks': 'error',
'no-loop-func': 'error',
'no-multi-spaces': 'warn',
'no-new-func': 'error',
'no-new-wrappers': 'error',
'no-param-reassign': 'error',
'no-proto': 'error',
'no-return-assign': 'error',
'no-return-await': 'error',
'no-script-url': 'error',
'no-self-compare': 'error',
'no-sequences': 'error',
'no-throw-literal': 'error',
'no-unused-expressions': 'error',
'no-useless-call': 'error',
'no-useless-concat': 'error',
'no-useless-return': 'error',
'no-void': 'error',
'no-with': 'error',
'prefer-named-capture-group': 'warn',
'prefer-regex-literals': 'warn',
radix: 'error',
'require-await': 'error',
'wrap-iife': ['error', 'inside'],
yoda: [
'warn',
'never',
{
exceptRange: true
}
]
}
}
};
];
86 changes: 44 additions & 42 deletions configs/ecmascript-6.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,44 +1,46 @@
/* https://eslint.org/docs/rules/#ecmascript-6 */
module.exports = {
rules: {
'arrow-body-style': ['warn', 'as-needed'],
'arrow-parens': ['warn', 'as-needed'],
'arrow-spacing': [
'warn',
{
before: true,
after: true
}
],
'generator-star-spacing': [
'warn',
{
before: false,
after: true
}
],
'no-duplicate-imports': 'error',
'no-useless-computed-key': 'warn',
'no-useless-constructor': 'warn',
'no-useless-rename': 'warn',
'no-var': 'warn',
'object-shorthand': [
'warn',
'always',
{
avoidQuotes: true,
avoidExplicitReturnArrows: true
}
],
'prefer-arrow-callback': 'warn',
'prefer-const': 'warn',
'prefer-destructuring': 'warn',
'prefer-rest-params': 'warn',
'prefer-spread': 'warn',
'prefer-template': 'warn',
'rest-spread-spacing': ['warn', 'never'],
'symbol-description': 'warn',
'template-curly-spacing': ['warn', 'never'],
'yield-star-spacing': ['warn', 'before']
export default [
{
rules: {
'arrow-body-style': ['warn', 'as-needed'],
'arrow-parens': ['warn', 'as-needed'],
'arrow-spacing': [
'warn',
{
before: true,
after: true
}
],
'generator-star-spacing': [
'warn',
{
before: false,
after: true
}
],
'no-duplicate-imports': 'error',
'no-useless-computed-key': 'warn',
'no-useless-constructor': 'warn',
'no-useless-rename': 'warn',
'no-var': 'warn',
'object-shorthand': [
'warn',
'always',
{
avoidQuotes: true,
avoidExplicitReturnArrows: true
}
],
'prefer-arrow-callback': 'warn',
'prefer-const': 'warn',
'prefer-destructuring': 'warn',
'prefer-rest-params': 'warn',
'prefer-spread': 'warn',
'prefer-template': 'warn',
'rest-spread-spacing': ['warn', 'never'],
'symbol-description': 'warn',
'template-curly-spacing': ['warn', 'never'],
'yield-star-spacing': ['warn', 'before']
}
}
};
];
38 changes: 20 additions & 18 deletions configs/errors.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,20 +1,22 @@
/* https://eslint.org/docs/rules/#possible-errors */
module.exports = {
rules: {
'no-await-in-loop': 'error',
'no-console': 'warn',
'no-debugger': 'warn',
'no-dupe-else-if': 'error',
'no-empty': [
'error',
{
allowEmptyCatch: true
}
],
'no-promise-executor-return': 'error',
'no-prototype-builtins': 'warn',
'no-template-curly-in-string': 'warn',
'no-useless-backreference': 'warn',
'require-atomic-updates': 'error'
export default [
{
rules: {
'no-await-in-loop': 'error',
'no-console': 'warn',
'no-debugger': 'warn',
'no-dupe-else-if': 'error',
'no-empty': [
'error',
{
allowEmptyCatch: true
}
],
'no-promise-executor-return': 'error',
'no-prototype-builtins': 'warn',
'no-template-curly-in-string': 'warn',
'no-useless-backreference': 'warn',
'require-atomic-updates': 'error'
}
}
};
];
73 changes: 51 additions & 22 deletions configs/import.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,23 +1,52 @@
module.exports = {
extends: ['plugin:import/errors', 'plugin:import/warnings'],
plugins: ['import'],
rules: {
'import/extensions': [
'warn',
'always',
{
js: 'never',
jsx: 'never',
ts: 'never',
tsx: 'never',
json: 'never'
}
],
'import/first': 'warn',
'import/no-cycle': 'error',
'import/no-mutable-exports': 'error',
'import/no-self-import': 'error',
'import/no-unused-modules': 'warn',
'import/no-useless-path-segments': 'warn'
import importPlugin from 'eslint-plugin-import';

export default [
{
plugins: {
import: importPlugin
},
rules: {
...(importPlugin.configs.errors.rules ?? {}),
...(importPlugin.configs.warnings.rules ?? {}),
'import/extensions': [
'warn',
'always',
{
js: 'never',
jsx: 'never',
ts: 'never',
tsx: 'never',
json: 'never'
}
],
'import/order': [
'error',
{
groups: ['builtin', 'external', 'internal', 'parent', 'sibling', 'type', 'object'],
pathGroups: [
{
pattern: '*.{css,scss}',
group: 'object',
position: 'after',
patternOptions: {
matchBase: true
}
}
],
'newlines-between': 'never',
alphabetize: {
order: 'asc',
caseInsensitive: true
}
}
],
'import/first': 'warn',
'import/newline-after-import': ['warn', { count: 1 }],
'import/no-cycle': 'error',
'import/no-mutable-exports': 'error',
'import/no-self-import': 'error',
'import/no-unused-modules': 'warn',
'import/no-useless-path-segments': 'warn'
}
}
};
];
32 changes: 19 additions & 13 deletions configs/jest-dom.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,20 @@
module.exports = {
extends: ['plugin:jest-dom/recommended'],
plugins: ['jest-dom'],
rules: {
'jest-dom/prefer-checked': 'warn',
'jest-dom/prefer-empty': 'warn',
'jest-dom/prefer-enabled-disabled': 'warn',
'jest-dom/prefer-focus': 'warn',
'jest-dom/prefer-required': 'warn',
'jest-dom/prefer-to-have-attribute': 'warn',
'jest-dom/prefer-to-have-style': 'warn',
'jest-dom/prefer-to-have-text-content': 'warn'
import jestDomPlugin from 'eslint-plugin-jest-dom';

export default [
{
plugins: {
'jest-dom': jestDomPlugin
},
rules: {
...(jestDomPlugin.configs.recommended?.rules ?? {}),
'jest-dom/prefer-checked': 'warn',
'jest-dom/prefer-empty': 'warn',
'jest-dom/prefer-enabled-disabled': 'warn',
'jest-dom/prefer-focus': 'warn',
'jest-dom/prefer-required': 'warn',
'jest-dom/prefer-to-have-attribute': 'warn',
'jest-dom/prefer-to-have-style': 'warn',
'jest-dom/prefer-to-have-text-content': 'warn'
}
}
};
];
20 changes: 13 additions & 7 deletions configs/jsx-a11y.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,14 @@
module.exports = {
extends: ['plugin:jsx-a11y/recommended'],
plugins: ['jsx-a11y'],
rules: {
'jsx-a11y/click-events-have-key-events': 'off',
'jsx-a11y/accessible-emoji': 'warn'
import jsxA11yPlugin from 'eslint-plugin-jsx-a11y';

export default [
{
plugins: {
'jsx-a11y': jsxA11yPlugin
},
rules: {
...(jsxA11yPlugin.configs?.recommended?.rules ?? {}),
'jsx-a11y/click-events-have-key-events': 'off',
'jsx-a11y/accessible-emoji': 'warn'
}
}
};
];
Loading