Don't show console on Windows #1506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When used inside GUI application, gix causes console window to appear temporarily, due to execution of git. Command needs special flags to prevent that. More details: https://stackoverflow.com/a/60958956
Byron
approved these changes
Aug 10, 2024
There was a problem hiding this comment.
Thanks a lot, this is a much appreciated fix!
There is also the gix-command crate which creates a std::process::Command instance to create git-style invocations, and it looks like it also doesn't turn this 'feature' off - I changed this now and also will assure that gix-command is used everywhere.
Byron
force-pushed
the
push-ysnqkzlzwuwq
branch
from
0ed66d1
to
cacc8af
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When used inside GUI application, gix causes console window to appear temporarily, due to execution of git.
Command needs special flags to prevent that. More details: https://stackoverflow.com/a/60958956