Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows build broken #16

Closed
Seeker14491 opened this issue Jul 30, 2018 · 0 comments
Closed

Windows build broken #16

Seeker14491 opened this issue Jul 30, 2018 · 0 comments

Comments

@Seeker14491
Copy link
Contributor

The last commit broke the build on Windows:

error[E0308]: match arms have incompatible types                         ] 0/2: open
  --> src\lib.rs:68:13
   |
68 | /             match path_ref.to_str() {
69 | |                 Some(s) => s.replace("&", "^&"),
70 | |                 None => path_ref,
   | |                         -------- match arm with an incompatible type
71 | |             }
   | |_____________^ expected struct `std::string::String`, found reference
   |
   = note: expected type `std::string::String`
              found type `&std::ffi::OsStr`

I'm planning on sending a PR that replaces the Windows code with the approach rustup uses anyways, which will take care of this issue too.

Seeker14491 added a commit to Seeker14491/open-rs that referenced this issue Jul 31, 2018
The code is adapted from rustup. Using ShellExecute is more efficient
and allows much better error handling. It also avoids some bugs, which
is the reason rustup switched to using this method.

Fixes Byron#16
@Byron Byron closed this as completed in #17 Aug 5, 2018
Byron pushed a commit that referenced this issue Aug 5, 2018
The code is adapted from rustup. Using ShellExecute is more efficient
and allows much better error handling. It also avoids some bugs, which
is the reason rustup switched to using this method.

Fixes #16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant