Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(windows): use SHOpenFolderAndSelectItems for folders to respect expand to open folder setting fixes #103 #104

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

Legend-Master
Copy link
Contributor

Use SHOpenFolderAndSelectItems instead of ShellExecuteExW for folders on Windows

Fix #103

@Legend-Master Legend-Master marked this pull request as ready for review November 14, 2024 15:10
Copy link
Owner

@Byron Byron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the fix!

I think the commit message needs to be revised though. Releases for me get easier with a fix: prefix, probably followed by the (#103) suffix. The subject would be a one-line reason for the change, followed by the exhaustive explanation in the body.

Without it, I am sure somebody else would come along and revert it because they preferred the previous behaviour.

I think the gist of the long explainer - the way I understood it - is that this form of opening the directory will respect a setting in the explorer that affects if the folder is selected in the sidebar as well. Without it, it will always select the folder.

Thank you.

@Legend-Master Legend-Master changed the title Use SHOpenFolderAndSelectItems for folders fix(windows): use SHOpenFolderAndSelectItems for folders to respect expand to open folder setting fixes #103 Nov 14, 2024
@Legend-Master
Copy link
Contributor Author

Changed the title, don't know if it's too long though, feel free to change it

@Byron
Copy link
Owner

Byron commented Nov 14, 2024

I am talking about the commit, which also needs a body. I want to avoid to rewrite verified commits.
Thank you.

@Legend-Master Legend-Master force-pushed the shopenfolderandselectitems branch from f454cb2 to 5951fa6 Compare November 14, 2024 15:50
@Legend-Master
Copy link
Contributor Author

Ah, I was thinking about squash merge, force pushed the previous commit

@Legend-Master Legend-Master force-pushed the shopenfolderandselectitems branch from 5951fa6 to 02cee81 Compare November 14, 2024 15:51
To respect 'expand to open folder' setting
Fixes Byron#103
@Legend-Master Legend-Master force-pushed the shopenfolderandselectitems branch from 02cee81 to 7595da7 Compare November 14, 2024 15:51
@Byron Byron merged commit d149825 into Byron:main Nov 14, 2024
7 checks passed
@Byron
Copy link
Owner

Byron commented Nov 14, 2024

That will do, thanks!

Here is the new release: https://github.com/Byron/open-rs/releases/tag/v5.3.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Opening folders with shellexecute-on-windows feature doesn't respect to 'expand to open folder' setting
2 participants