Revert usage of Command::new(explorer) to ShellExecuteW #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks a lot for your help - v1.5.1 was just released. |
matoous
added a commit
to matoous/open-rs
that referenced
this pull request
Feb 5, 2023
Use std `Command` instead of `ShellExecuteW` from windows sys crate. This change was already attempted in: Byron#25 and later reverted in: Byron#27 and it it seems that it didn't work due to incorrect usage of `explorer` instead of `cmd /c start`. (see helix-editor/helix#5820 (comment) for detailed explanation). Related: helix-editor/helix#5820
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This restores the previous behavior on windows, and sticks to the recommended way of opening files on windows.