Build script doesn't work when cross compiling to Windows #39
Comments
|
Hey, sorry for the slow response and thanks for the suggestion. I'm going to make the change, you suggested, but I'm afraid it still wouldn't work due to this: microsoft/windows-rs#638. In the meantime consider using version 1 of this crate. |
|
@Jake-Shadle I couldn't find a way to write to privately so I'm asking here: would you be interested in taking this crate over? I'd like to step away from maintaining it. |
|
Uhh sorry no, I only filed this issue due to Jake-Shadle/xwin#10, I've never used this crate myself. |
|
That's alright, thanks for the quick response anyways. |
|
@Byron I can see that you are depending on this crate for |
|
@ArturKovacs Thanks for asking, I am happy to take it over. I also hope you would still be available for occasional help on Windows (if issues come up) as I have decent access only to MacOS. |
|
I'm wondering if we should transfer ownership to your account, @Byron |
|
I am open to that, please feel free to initiate the transfer. |
|
Looks that this issue is already fixes in latest version of windows-rs, so only updating it from 0.9.0 version is required Lines 51 to 54 in 50ab31a |
but it doesn't work in the build script for some reason.
…fo. (#39) We use absolute paths now without trying to generate a relative path based on some top directory as the latter seems to be causing inconsistencies on some linux distros, as the restore path ends up being incorrect. Rather go with the absolute truth and don't fiddle with path transformations at all to make it work everywhere.
|
If somebody wants to give #49 a shot…! I brought the |
|
Please take a look at the latest release for a fix to this problem. Since it uses no build script, there should be no related issues anymore. Even though I am closing this issue in anticipation, please feel free to reopen if something else pops up. |
This allows to turn chrono support off without actually affecting the ability to trash and restore items. `chrono` still has issues to dubious local-time support which relies on a c-library function that can cause undefined behaviour as it accesses an environment variable in a non-threadsafe fashion.
The build script doesn't generate bindings unless running on Windows which means compiling on a non-Windows platform targeting Windows won't generate the bindings and thus fail building as seen in Jake-Shadle/xwin#10. The build script should use
CARGO_CFG_TARGET_OSto determine whether it should build the bindings or not.The text was updated successfully, but these errors were encountered: