List valid trash bin paths #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a small refactor to support listing Freedesktop compliant trash bins. Enumerating trash bins, which may reside across mount points or be invalid in some way, is useful for end users who need the paths themselves rather than the items in the trash.
Windows' `Recycle Bin` is a virtual folder which does not have a path. Sources: * https://learn.microsoft.com/en-us/windows/win32/shell/knownfolderid * https://learn.microsoft.com/en-us/windows/win32/api/shobjidl_core/ne-shobjidl_core-kf_category * https://learn.microsoft.com/en-us/windows/win32/api/shlobj_core/nf-shlobj_core-shgetknownfolderpath
joshuamegnauth54
force-pushed
the
trash-locations
branch
from
a27dfc7
to
32719fb
Compare
|
Thanks a lot for contributing! Windows really likes to crash these days and maybe it's even related to what is triggered by the tests (and thus is legit). But that's another story. I also see how difficult this is to unit-test, and think it's OK to not have more than a doc-test. And even though I'd want to avoid platform-specific APIs, I see how having this can be useful where it is supported. |
|
The new release is available here: https://github.com/Byron/trash-rs/releases/tag/v4.1.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small refactor to support listing Freedesktop compliant trash bins.
Enumerating trash bins, which may reside across mount points or be invalid in some way, is useful for end users who need the paths themselves rather than the items in the trash.