macOS: Use objc2-foundation
#107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madsmtm
commented
May 15, 2024
Comment on lines
-105
to
-107
| // WARNING: I don't know why but if we try to call release on the url, it sometimes | ||
| // crashes with SIGSEGV, so we instead don't try to release the url | ||
| // let url = OwnedObject { ptr: url }; |
There was a problem hiding this comment.
The reason is that fileURLWithPath: returns an autoreleased instance, as documented in the memory management rules. objc2 handles these details for you.
madsmtm
commented
May 15, 2024
madsmtm
commented
May 15, 2024
61 tasks
|
Not sure why the Windows build failed, but I don't think it's my fault? |
Byron
approved these changes
May 15, 2024
There was a problem hiding this comment.
This is fantastic, thanks so much!
The new version is indeed much simpler, and I for one am happy to offload that work to a crate that knows what it is doing.
This comes at the cost of another dependency, maybe increasing compile times, but I think it's even if that's the case, it's a price worth paying.
And indeed, the Windows failure is spurious, probably indicating that some memory corruption is happening there, but who knows.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
objc2project is the successor toobjcandcocoa, and contains automatically generated bindings to the Foundation framework (and many other frameworks), while ensuring that memory management rules are upheld.This allows
trashto get rid of a bunch of complexunsafecode and error cases that can't happen (most of these are cases where the APIs are documented to not return NULL).