Upgrade windows crate from v0.37 to v0.43 #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There were some unrelated Clippy failures on Linux (probably related to a new Clippy version), fixed. |
|
Thanks so much for your help with this! And by the looks of it, the churn is worth it as the code looks more and more idiomatic! One day, Windows having a native Rust API might actually want to make me write software for it 😅. |
|
And here is the release, I made it a major one maybe for the wrong reason. Can different versions of the |
Yep I believe so! Compiling |
rgwood
added a commit
to nushell/nushell
that referenced
this pull request
Nov 29, 2022
This upgrades the `windows` and `trash` crates so we are only compiling 1 version of the `windows` crate ([I recently upgraded the version used in `trash`](Byron/trash-rs#58)). I was hoping that this would lead to some decent compile time improvements, but unfortunately it did not. Compiling 1 version of `windows` with all the features unified is about as slow as compiling 2 versions with distinct feature sets. Still, might as well upgrade.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello it's me from #51 again!
The
windowscrate has seen a bit more churn recently, and I figured it might be worth proactively upgrading the version used bytrash-rs.Functionality-wise this should not change anything. I measured compile times before+after and it seems about 5% faster now.