Add interface for specifying brancher labels and settings #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martijneichelsheim
approved these changes
Nov 22, 2022
AlexanderGrooff
approved these changes
Nov 23, 2022
| @@ -14,6 +14,8 @@ | |||
| $productionStage->addServer('appname.hypernode.io'); | |||
|
|
|||
| $testStage = $configuration->addStage('test', 'example.com'); | |||
| $testStage->addBrancherServer('appname'); | |||
| $testStage->addBrancherServer('appname') | |||
| ->setLabels(['stage=test', 'ci_ref=' . \getenv('GITHUB_RUN_ID') ?: 'none']) | |||
There was a problem hiding this comment.
These labels are all formatted as X=Y, but there isn't some validation based on this format right? Any format of label is allowed?
There was a problem hiding this comment.
Any format is allowed indeed
| */ | ||
| public function setLabels(array $labels): self | ||
| { | ||
| $this->setOption(self::OPTION_HN_BRANCHER_LABELS, $labels); |
There was a problem hiding this comment.
Do you think it's wise to add input validation in the client here or should we let the API validate the data?
There was a problem hiding this comment.
Yes I think so, since this is a very light component, let's add the validation in hypernode-deploy
tdgroot
force-pushed
the
brancher_labels_and_settings
branch
from
0d97601 to
de45e75
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The configuration can be done as follows:
These labels can be used in Hypernode Deploy to determine what brancher nodes to clean up, for example: clean up brancher servers matching specified stage and their labels.