This repository was archived by the owner on Dec 20, 2023. It is now read-only.
Handle configuration validation and plugin installation in a Vagrant plugin #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vdloo
force-pushed
the
move-config-mgmtlogic-into-vagrant-hypconfigmgmt-plugin
branch
from
d2d807f to
fbae68a
Compare
|
blocked because of an issue with vagrant 1.8.4 see hashicorp/vagrant#7493 edit: uploaded the gem to https://rubygems.org/gems/vagrant-hypconfigmgmt, plugin can now be installed with "vagrant plugin install vagrant-hypconfigmgmt" |
vdloo
force-pushed
the
move-config-mgmtlogic-into-vagrant-hypconfigmgmt-plugin
branch
2 times, most recently
from
3a95c28 to
4263944
Compare
|
@hongaar @timneutkens what do you think? |
|
Sweet. 👍 for a cleaner Vagrantfile and offloading configuration to a separate plugin. |
|
Cool stuff, seems like a good solution! 👍 |
The basic hypernode-vagrant box can now be configured and booted by cloning the repo and running "vagrant up" three times and following the dialogue. Vagrant needs to be started three consecutive times because it loads all configurations during initialization, not during runtime. When we change the configuration in the Vagrant process we need to restart Vagrant for the changes to take effect. 1. Install the vagrant-hypconfigmgmt plugin 2. Configure the local.yml and install other required plugins 3. Boot the box When the box is properly configured and all the required plugins is installed one vagrant up is sufficient.
vdloo
force-pushed
the
move-config-mgmtlogic-into-vagrant-hypconfigmgmt-plugin
branch
from
4263944 to
c58c35c
Compare
vdloo
force-pushed
the
move-config-mgmtlogic-into-vagrant-hypconfigmgmt-plugin
branch
from
df26ca8 to
db38390
Compare
…to move-config-mgmtlogic-into-vagrant-hypconfigmgmt-plugin Conflicts: Vagrantfile
|
Changes Unknown when pulling c368ce0 on move-config-mgmtlogic-into-vagrant-hypconfigmgmt-plugin into * on master*. |
vdloo
force-pushed
the
move-config-mgmtlogic-into-vagrant-hypconfigmgmt-plugin
branch
from
0d54d9c to
a553f6f
Compare
vdloo
deleted the
move-config-mgmtlogic-into-vagrant-hypconfigmgmt-plugin
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bundle vagrant-hypconfigmgmt plugin
The basic hypernode-vagrant box can now be configured and booted by cloning the repo and running "vagrant up" three times and following the dialogue. Vagrant needs to be started three consecutive times because it loads all configurations during initialization, not during runtime. When we change the configuration in the Vagrant process we need to restart Vagrant for the changes to take effect.
When the box is properly configured and all the required plugins is installed one vagrant up is sufficient so this will have no impact if you (correctly) manually manage your local.yml file. Prompting for options can be disabled by removing
config.hypconfigmgmt.enabled = truein the Vagrantfile (but the config validation will also be gone so beware).Fresh install:
What the configuration file will look like after completing the dialogue:
Running "vagrant up" again after only changing the Magento version from 2 to 1 in the local.yml configuration file.
The resulting local.yml (note the disabled mounted directory)
tldr: simplified installation to calling "vagrant up" three times. settings are prompted during "vagrant up". magento1 and magento2 mount paths are swapped out when the version is changed in the config. Platform for moving complexity out of the Vagrantfile and into the bundled plugin.