Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix log #427

Merged
merged 2 commits into from
Feb 22, 2024
Merged

Fix log #427

merged 2 commits into from
Feb 22, 2024

Conversation

InnocentBug
Copy link
Collaborator

Description

BUGFIX: enable log message about validating nodes again.

Changes

Remove api.verbose attribute as it complicates the design unnecessarily.
If a user is advanced enough to want to change the log level, they can use the python.logging module interface directly.

Known Issues

Slight change in userfacing interface (removal of api.verbose)

Notes

Checklist

  • My name is on the list of contributors (CONTRIBUTORS.md) in the pull request source branch.
  • I have updated the documentation to reflect my changes.
  • [ x My code changes have been verified by automated tests and pass all relevant test scenarios.

@InnocentBug InnocentBug self-assigned this Feb 21, 2024
Copy link

trunk-io bot commented Feb 21, 2024

Merging to develop in this repository is managed by Trunk.

  • To merge this pull request, check the box to the left or comment /trunk merge below.

@InnocentBug InnocentBug changed the base branch from main to develop February 21, 2024 21:53
@InnocentBug InnocentBug merged commit bb545c4 into develop Feb 22, 2024
11 checks passed
@InnocentBug InnocentBug deleted the fix-log branch March 27, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants