Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added ZTM React project 'robofriends' #86

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

added ZTM React project 'robofriends' #86

wants to merge 2 commits into from

Conversation

a-hend
Copy link
Collaborator

@a-hend a-hend commented May 4, 2023

Completed the 'robofriends' tutorial on ZTM using React. Parts of this seemed pretty intuitive and fun, other parts were confusing. Looking forward to learning more!

Copy link
Owner

@C-STYR C-STYR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Despite having node_modules listed in your .gitignore, they're still being included here. Since this is a common problem, it would be a good exercise to update .gitignore or otherwise modify your PR to not include the node_modules directory...

@a-hend
Copy link
Collaborator Author

a-hend commented May 8, 2023

Ok, I've updated the .gitignore file, but I'm assuming that won't fix the problem because the files are already in the pull request. I tried running git rm -r --cached node_modules but that did not work... I got a fatal: pathspec "node_modules" did not match any files.

@a-hend
Copy link
Collaborator Author

a-hend commented May 8, 2023

So I tried running git rm -r --cached /node_modules and got a message that the file is outside the repository. Is this not working because the pull request has not been approved?

@a-hend
Copy link
Collaborator Author

a-hend commented May 8, 2023

Finally, do you recommend just going into the pull request and manually deleting all 'node_module` files now that the .gitignore file has been updated?

@C-STYR
Copy link
Owner

C-STYR commented May 10, 2023

sorry - no help on this one :)
this is a really good opportunity to "snuggle with the struggle" and figure out how to remove files from a PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants