C2DEVEL-15626: Add methods for Kafka topics #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CrocBomber
force-pushed
the
C2DEVEL-15626
branch
from
8815bf6 to
5ba1b23
Compare
CrocBomber
force-pushed
the
C2DEVEL-15626
branch
from
5ba1b23 to
a37c578
Compare
astroline
reviewed
Oct 21, 2024
| @@ -533,7 +573,7 @@ | |||
| "serviceCaption": {"shape": "String"}, | |||
| "serviceType": {"shape": "String"}, | |||
| "protocol": {"shape": "String"}, | |||
| "port": {"shape": "String"} | |||
| "port": {"shape": "Integer"} | |||
There was a problem hiding this comment.
А не развалятся ли клиенты после такой замены? Террафрм уже поддерживает эти поля?
There was a problem hiding this comment.
Думешь может развалиться? Я это правил как ошибку, т.к. по коду тут у нас всегда int возращается. И он именно в коде который возвращается, а не который вводится пользователем.
There was a problem hiding this comment.
Простите, что врываюсь, эти поля не поддерживаются терраформом )
CrocBomber
force-pushed
the
C2DEVEL-15626
branch
from
a37c578 to
cb44b92
Compare
CrocBomber
force-pushed
the
C2DEVEL-15626
branch
from
cb44b92 to
cae4917
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes C2DEVEL-15626
based on #133