Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing single quote in error message #570

Merged
merged 4 commits into from
May 26, 2021

Conversation

Caleb-Irwin
Copy link
Contributor

Without the extra quotation mark, you can not know if the first quotation mark is part of the problem or part of the error message. Issue: #569

Without the extra quotation mark, you can not know if the first quotation mark is part of the problem or part of the error message.
@dustinsmith1024
Copy link
Contributor

Thanks - If you fix the test I'll get this merged.

Summary of all failing tests
FAIL packages/parse/__tests__/CsvParsingStream.spec.ts
  ● CsvParserStream › should emit an error for malformed rows

    expect(received).toBe(expected) // Object.is equality

    Expected: "Parse Error: expected: ',' OR new line got: 'a'. at 'a   \", Las"
    Received: "Parse Error: expected: ',' OR new line got: 'a'. at 'a   \", Las'"

      47 |         stream
      48 |             .on('error', (err: Error) => {
    > 49 |                 expect(err.message).toBe(message);
         |                                     ^
      50 |                 if (!called) {
      51 |                     called = true;
      52 |                     resolve();

      at CsvParserStream.<anonymous> (packages/parse/__tests__/CsvParsingStream.spec.ts:49:37)
      at CsvParserStream.emit (packages/parse/src/CsvParserStream.ts:71:22)

Fixed Test for commit.
Third times the charm?
@coveralls
Copy link

coveralls commented Feb 10, 2021

Pull Request Test Coverage Report for Build 553310070

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 96.063%

Totals Coverage Status
Change from base Build 449487237: 0.0%
Covered Lines: 741
Relevant Lines: 757

💛 - Coveralls

@dustinsmith1024 dustinsmith1024 merged commit 8c0dc09 into C2FO:master May 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants