removed references to ParameterTable #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the PR! We were already planning on updating our code to the current Qiskit, this will certainly help. We'll also get our requirements.txt and pyproject.toml updated so that our PyPI package has its dependencies correct, too. |
This was referenced Oct 15, 2024
Closed
|
That's great @tjstavenger-pnnl ... please let me know if I can further assist in any way! |
|
Will be fixed by #123 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Qiskit 1.2, the protect member
_parameter_tableof theQuantumCircuitclass is managed in the Rust domain and is inaccessible from Python. (It is further explained in this Qiskit PR). This PR removes reference to the parameter table in theCVCircuitclass, which had no downstream dependencies. Nowbosonic-qiskitshould be compatible with Qiskit >= 1.2.Also fixed some formatting issues by running
black.