Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Diffusion metrics fields #472

Merged
merged 81 commits into from
Jul 24, 2024
Merged

Diffusion metrics fields #472

merged 81 commits into from
Jul 24, 2024

Conversation

nfarabullini
Copy link
Contributor

Implementation of:

  • mask_hdiff
  • zd_diffcoef_dsl
  • zd_vertoffset_dsl
  • zd_intcoef_dsl

ajocksch and others added 30 commits March 22, 2024 18:09
@ajocksch
further interpolation coefficients
af43771
@ajocksch
progress
b1a7e5d
@ajocksch
progress
c2d201c
@ajocksch
ddxt_z_full
89949b4
@ajocksch
model/common/src/icon4py/model/common/interpolation/interpolation_fie…
b05bbee 
…lds3.py
@ajocksch
progress gt4py
8aac5e2
@ajocksch
progress gt4py
9ecd7e3
@ajocksch
progress numpy to gt4py
bac95e4
@ajocksch
progress ddqz_z_full_e
596ec48
@ajocksch
Merge branch 'main' of github.com:C2SM/icon4py into greenline_interpo…
6bd552c 
…lation_coefficients3_aj
@nfarabullini
partial implementation of vwind_impl_wgt and vwind_expl_wgt
cb68e6c
@ajocksch
small progress
3d71578
@nfarabullini
some implementation for fields
57ca79f
@nfarabullini @halungge
Update model/common/src/icon4py/model/common/interpolation/interpolat…
61ac852 
…ion_fields3.py

Co-authored-by: Magdalena <luzm@ethz.ch>
@nfarabullini
applied changes after PR review
c489f8a
@nfarabullini
one more change
2492205
@nfarabullini
Merge branch 'main' of https://github.com/C2SM/icon4py into greenline…
9e92338 
…_interpolation_coefficients3_aj
@nfarabullini
fixed pre-commit
7412635
@nfarabullini
edits following review
da8d98a
@nfarabullini
docstring edit
53c5ac6
@nfarabullini
small edits
ec468eb
@nfarabullini
merge with other branch
c3c4427
@nfarabullini
edits
54363af
@nfarabullini
merge with upstream
8eed019
@nfarabullini
edits
ddfd413
@nfarabullini
further edits
76d5554
@nfarabullini
small edit
308b1e4
@nfarabullini
added comment for skipping
fc9d8e2
@nfarabullini
file split
3608bb7
@nfarabullini
Merge branch 'main' of https://github.com/C2SM/icon4py into metrics_f…
41ab599 
…ields_second_batch
halungge
halungge requested changes May 31, 2024
View reviewed changes
model/common/src/icon4py/model/common/metrics/metric_fields.py Outdated Show resolved Hide resolved
model/common/src/icon4py/model/common/test_utils/serialbox_utils.py Outdated Show resolved Hide resolved
model/common/src/icon4py/model/common/metrics/metric_fields.py Outdated Show resolved Hide resolved
model/common/src/icon4py/model/common/metrics/metric_fields.py Outdated Show resolved Hide resolved
model/common/tests/metric_tests/test_metric_fields.py Outdated Show resolved Hide resolved
model/common/src/icon4py/model/common/metrics/stencils/compute_diffusion_metrics.py Outdated Show resolved Hide resolved
model/common/src/icon4py/model/common/metrics/metric_fields.py Outdated Show resolved Hide resolved
model/common/tests/metric_tests/test_metric_fields.py Outdated Show resolved Hide resolved
model/common/tests/metric_tests/test_metric_fields.py Outdated Show resolved Hide resolved
@nfarabullini
Copy link
Contributor Author

launch jenkins spack

@nfarabullini
Copy link
Contributor Author

cscs-ci run default

@nfarabullini
Copy link
Contributor Author

cscs-ci run default

@github-actions GitHub Actions
Copy link

Mandatory Tests

Please make sure you run these tests via comment before you merge!

  • cscs-ci run default
  • launch jenkins spack

Optional Tests

To run benchmarks you can use:

  • cscs-ci run benchmark

To run tests and benchmarks with the DaCe backend you can use:

  • cscs-ci run dace

In case your change might affect downstream icon-exclaim, please consider running

  • launch jenkins icon

For more detailed information please look at CI in the EXCLAIM universe.

@nfarabullini
Copy link
Contributor Author

launch jenkins spack

@halungge halungge self-requested a review July 24, 2024 15:07
@nfarabullini nfarabullini merged commit e0a5202 into main Jul 24, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@halungge halungge halungge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nfarabullini @halungge @ajocksch