Simple MaskedArray implementation #554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s not implementd in cupy.
Open
OngChia
approved these changes
Sep 19, 2024
model/common/src/icon4py/model/common/decomposition/definitions.py
Outdated
Show resolved
Hide resolved
OngChia
approved these changes
Sep 19, 2024
model/common/src/icon4py/model/common/decomposition/definitions.py
Outdated
Show resolved
Hide resolved
| def __init__(self, klevels: int): | ||
| self._global_index:dict[Dimension, MaskedArray] = {} | ||
| self._klevels = klevels | ||
|
|
||
| class EntryType(IntEnum): | ||
| ALL = 0 | ||
| OWNED = 1 | ||
| HALO = 2 | ||
|
|
||
| @builder.builder | ||
| def with_dimension(self, dim: Dimension, global_index: np.ndarray, owner_mask: np.ndarray): |
model/common/src/icon4py/model/common/decomposition/definitions.py
Outdated
Show resolved
Hide resolved
OngChia
reviewed
Sep 19, 2024
| @@ -8,14 +8,14 @@ | |||
|
|
|||
| from __future__ import annotations | |||
|
|
|||
| import dataclasses | |||
| import functools | |||
| import logging | |||
| from dataclasses import dataclass | |||
| from enum import IntEnum | |||
fix typo in dunder function
|
Mandatory Tests Please make sure you run these tests via comment before you merge!
Optional Tests To run benchmarks you can use:
To run tests and benchmarks with the DaCe backend you can use:
In case your change might affect downstream icon-exclaim, please consider running
For more detailed information please look at CI in the EXCLAIM universe. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(FIX) poor man s implementation of a Masked Array as numpy.ma has no correspondence in cupy.
Additional fixes: