Fix index conversion int32 vs int64 #555
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Mandatory Tests Please make sure you run these tests via comment before you merge!
Optional Tests To run benchmarks you can use:
To run tests and benchmarks with the DaCe backend you can use:
In case your change might affect downstream icon-exclaim, please consider running
For more detailed information please look at CI in the EXCLAIM universe. |
havogt
commented
Sep 20, 2024
| @@ -187,7 +187,7 @@ def index(self, domain: Domain) -> gtx.int32: | |||
| assert ( | |||
| 0 <= index <= self._bottom_level(domain) | |||
| ), f"vertical index {index} outside of grid levels for {domain.dim}" | |||
| return index | |||
| return gtx.int32(index) | |||
There was a problem hiding this comment.
The problem is 4 lines up, when we do index += domain.offset, and the default initialization to 0 of offset in Domain.
This file seems to require more cleanup and a strategy for doing this as there are sprinkled many gtx.int32 inconsistently...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.