Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace 2-elements sequences by Pair utility for double buffering #590

Merged
merged 68 commits into from
Dec 3, 2024
Merged

Replace 2-elements sequences by Pair utility for double buffering #590

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
68 commits
Select commit Hold shift + click to select a range
f80987e
Initial refactoring to use Swapping for double buffering
egparedes Nov 6, 2024
ec37607
More refactorings and cleanups in the driver.
egparedes Nov 7, 2024
3136ba3
Use keyword arg in DriverParams
egparedes Nov 7, 2024
cc12537
Extend docstrings
egparedes Nov 7, 2024
bbeab74
Extend double buffer changes to solve_nonhydro
egparedes Nov 7, 2024
3a83830
Refactor Swapping to generic Pair class, and specialized it for diffe…
egparedes Nov 11, 2024
84d544c
Change common.utils import alias
egparedes Nov 11, 2024
4a8605a
Recover methods of Pair deleted by accident in previous commits
egparedes Nov 11, 2024
9098322
Format
egparedes Nov 11, 2024
d0c8919
Export `namedproperty` utility
egparedes Nov 11, 2024
04736c9
Update Pair to have both accessors read/writable by default
egparedes Nov 11, 2024
283e422
Replace `ddt_vn_apc_ntl1` and `ddt_vn_apc_ntl2` by `ddt_vn_apc_pc`
egparedes Nov 11, 2024
8fb1a2b
Replace `ddt_w_adv_ntl1` and `ddt_w_adv_ntl2` by `ddt_w_adv_pc`
egparedes Nov 12, 2024
c06fe90
Fix Pair
egparedes Nov 12, 2024
0fc58f6
Format issues
egparedes Nov 12, 2024
81afd2e
Fixes
egparedes Nov 12, 2024
9cc4967
More replacements of prognostic_states lists
egparedes Nov 12, 2024
24110c4
More replacements
egparedes Nov 12, 2024
857a762
Final missing replacement (in theory)
egparedes Nov 13, 2024
636944f
Fixes
egparedes Nov 13, 2024
12d3a08
More missing replacements in tests
egparedes Nov 13, 2024
5f9b795
Update model/driver/src/icon4py/model/driver/icon4py_driver.py
egparedes Nov 13, 2024
5bfd3c4
More missing replacements and deletions.
egparedes Nov 13, 2024
e633ba9
Fix
egparedes Nov 13, 2024
9a8f1fe
More fixes
egparedes Nov 13, 2024
090241a
Simplify Pair base class.
egparedes Nov 13, 2024
d4db5f0
Simplify docstrings
egparedes Nov 13, 2024
1074f53
Testing
egparedes Nov 13, 2024
c2e0026
Fixes after debugging
egparedes Nov 14, 2024
cb7327d
More fixes
egparedes Nov 14, 2024
7f3b229
Refactorings and style
egparedes Nov 14, 2024
efad473
Minor fix to Pair and namedproperty utility classes
egparedes Nov 15, 2024
b3447fb
Rename named_property
egparedes Nov 15, 2024
031e0f4
Missing changes from previous commits
egparedes Nov 15, 2024
ba05499
New refactoring of Pair adding direct item access.
egparedes Nov 18, 2024
a1111e7
More fixes
egparedes Nov 19, 2024
26c435c
Fix remaining failing tests
egparedes Nov 19, 2024
55eae93
Merge branch 'main' into double_buffer_backup
egparedes Nov 20, 2024
f18ad08
Renaming symbols
egparedes Nov 20, 2024
333897f
Fix merging errors
egparedes Nov 21, 2024
69ad9c7
Rename NextStepPair
egparedes Nov 21, 2024
186c93d
Fix spellings
egparedes Nov 21, 2024
62873ba
Fix typos and expand documentation
egparedes Nov 21, 2024
2f97371
Readability improvements
egparedes Nov 22, 2024
da44a25
Address reviewer's comments.
egparedes Nov 22, 2024
0a6772d
Enhance diagnostic states swap documentation.
egparedes Nov 22, 2024
d8eb6f6
Fix style of comments
egparedes Nov 22, 2024
da4c9c9
Rename and enhance documentation related to the velocity tendencies i…
egparedes Nov 22, 2024
4801651
Minor rename
egparedes Nov 22, 2024
857e2ad
Add forgotten changes from Pair to TimeStepPair
egparedes Nov 22, 2024
74bf1fa
Merge branch 'main' into use_double_buffer_class
egparedes Nov 22, 2024
93cc389
Fix bug in dycore wrapper
egparedes Nov 22, 2024
1825590
Remove unneeded indices in dycore_wrapper
egparedes Nov 22, 2024
db06eab
Make next read-write in TimeStepPair
egparedes Nov 27, 2024
55359b8
fix update_time_levels_for_velocity_tendencies and modify its docstring
OngChia Nov 27, 2024
51341d8
fix duplicated swapping in test_run_solve_nonhydro_multi_step for the…
OngChia Nov 27, 2024
982774f
remove print statement
OngChia Nov 27, 2024
d3b0ab8
fix bug in test multi substeps
OngChia Nov 27, 2024
b9ede34
review changes
OngChia Nov 28, 2024
fa712ab
Merge branch 'main' into use_double_buffer_class
OngChia Nov 28, 2024
42e1fb7
fix ddt_w_apc index in test_timeloop
OngChia Nov 29, 2024
00b114c
frozen_first for current of TimeStepPair
OngChia Nov 29, 2024
f1f85f9
Merge branch 'main' into use_double_buffer_class
OngChia Nov 29, 2024
f8a3c56
review changes
OngChia Dec 2, 2024
977ac8b
Merge branch 'main' into use_double_buffer_class
OngChia Dec 2, 2024
5dc51c6
remove print swap
OngChia Dec 2, 2024
0f6908a
remove comments
OngChia Dec 2, 2024
d2c779d
Remove get/set item of pair class
egparedes Dec 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading
Loading