-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use explicit zlib-ng dependency for icon #1040
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
launch jenkins |
lxavier
approved these changes
Jan 20, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
test with ICON : compilation ok, all depencies from upstream are used
the errors of the ci are related to permisions, could be because the branch is from a Fork. I tested manually that ICON compile, so I will merge in dev_0.22 branch |
jonasjucker
added a commit
that referenced
this pull request
Jan 28, 2025
* Set submodule spack to v0.22.2 * fdb: Remove package * metkit: Remove package * py-frozendict: Remove package * xpmem: Remove package * py-hatchling: Update from upstream * py-tabulate: Update from upstream * icon-ham: Use spack/icon * icon: Split package * py-lark: Remove package * Remove unnecessary tests * Migrate unit tests to pytest * Rename icon to icon-c2sm * cosmo: Remove package * Jenkins: Use mch/prgenv-icon:rc1 * GitHub Action: Apply Pep8-formatting * Add tests for 'spack find' and 'spack compilers'. * Start uenv in test stages * deactivate * Simplify run_with_spack * Keep venv * Bring back devirtualization * Update uenv * Use .venv * GitHub Action: Apply Pep8-formatting * Shuffle Jenkinsfile * revert * uenv * revert clean env * Remove fdb-fortran * flexpart-cosmo: Add workaround * Update icon-mch tests * Typo * icontools: Workaround * Fix some icon tests * Fix type * Remove icon-mch gcc test * GitHub Action: Apply Pep8-formatting * Revert "cosmo: Remove package" This reverts commit 2a7a337. * cosmo: remove package * cosmo: remove tests * Fix icon-mch test * fix icon test * eccodes: remove version 2.19.0 * Clean up system tests * GitHub Action: Apply Pep8-formatting * Update uenv * cosmo-eccodes-definitions: Remove versions 2.19.0.x * icon-mch: Add workarounds * icon-c2sm: Inherit from icon * Improve tests * Disable failing package tests. * Move mpi workaround * GitHub Action: Apply Pep8-formatting * icon-mch: Remove gcc test and add version tests * icon-c2sm: Remove copy_runscript_related_input_files because there's no self.out_of_source_build * icon-mch: fix tags * icon: Set new maintainer * Rename icon-c2sm to icon * Use require * GitHub Action: Apply Pep8-formatting * pytorch-fortran-proxy: requires gcc * GitHub Action: Apply Pep8-formatting * dirty gt4py fix * GitHub Action: Apply Pep8-formatting * rm exclaim * GitHub Action: Apply Pep8-formatting * fix test and add icon-exlcaim * GitHub Action: Apply Pep8-formatting * make out-of-source work * GitHub Action: Apply Pep8-formatting * fix url * rm file * update test * cleanup * GitHub Action: Apply Pep8-formatting * fix * fix version * rm include * GitHub Action: Apply Pep8-formatting * fix icon-ham * add maintainer * Update repos/c2sm/packages/icon-exclaim/package.py Co-authored-by: Dominic Hofer <6570912+dominichofer@users.noreply.github.com> * GitHub Action: Apply Pep8-formatting * change * GitHub Action: Apply Pep8-formatting * disable version * GitHub Action: Apply Pep8-formatting * remove loop-exchange * fix icon * dirty fix icon4py * readd loop-exchange * Update package.py Set default loop-exchange to False * fix bug again of serialbox dep, cleanup * reintroduce skip configure * remove libtorch * upgrade docs (#1038) * upgrade docs * add yaml example * update docs * update docs * Update cosmo-eccodes-definitions versions to 2.36.0.3 This is used with eccodes 2.36.4 This is required to test v8 env on balfrin * use explicit zlib-ng dependency for icon (#1040) * use rc 4 * remove obsolete packages * adjust integration tests * upgrade manual to build icon --------- Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: juckerj <39263956+jonasjucker@users.noreply.github.com> Co-authored-by: Daniel Hupp <daniel.hupp@meteoswiss.ch> Co-authored-by: Jonas Jucker <jonas.jucker@c2sm.ethz.ch> Co-authored-by: Xavier Lapillonne <7485594+lxavier@users.noreply.github.com> Co-authored-by: Ben Cumming <bcumming@cscs.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explicitly use
zlib-ng
instead ofzlib
to forceicon
to usezlib-ng
provided by the CSCS software stack.