Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update UpstreamManagement.rst #904

Merged
merged 2 commits into from
Feb 9, 2024
Merged

Update UpstreamManagement.rst #904

merged 2 commits into from
Feb 9, 2024

Conversation

dominichofer
Copy link
Contributor

@dominichofer dominichofer commented Jan 26, 2024

Open for comments

Copy link
Contributor

github-actions bot commented Jan 26, 2024

PR Preview Action v1.4.7
Preview removed because the pull request was closed.
2024-02-09 10:14 UTC


Upgrade sysconfigs
----------------------
To copy the alp's env files, use https://github.com/C2SM/spack-c2sm/blob/main/sysconfigs/copy_alps_env_files_from.sh
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would need a bit more - to me the is related to a new upstream , for example:
When CSCS provide an update software stack upstream on alps the corresponding environement file need to be updated. The scripts ./sysconfigs/copy_alps_env_files_from.sh can be used

SHoudl you not call it from inside the spack-c2sm , otherwise how do you copy at the write place (since you provide a http link is not clear)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed in next commit.

Copy link
Contributor

@faeglas faeglas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better docs, short and precise 👍

@dominichofer dominichofer merged commit 0fdb53c into main Feb 9, 2024
2 checks passed
@dominichofer dominichofer deleted the dominichofer-patch-2 branch February 9, 2024 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants