limbo: initial client testcases #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: William Woodruff <william@trailofbits.com>
|
|
No regressions found.
Signed-off-by: William Woodruff <william@trailofbits.com>
Signed-off-by: William Woodruff <william@trailofbits.com>
New testcasesThere are new testcases in this change. openssl-3.2.1
openssl-1.1
openssl-3.1.5
gocryptox509-go1.22.0
rust-webpki
rustls-webpki
openssl-3.0.13
pyca-cryptography-42.0.5
|
3 tasks
Signed-off-by: William Woodruff <william@trailofbits.com>
|
I'm not going to have time to give this a proper review in the near-time frame, not sure how you'd like to proceed. |
No worries. I was thinking I could merge this as-is (since the existing limbo harness upstream should skip them), but this can also sit until you have more review time + I have the time to finish the actual client implementation, which will probably be next week at the earliest 🙂 |
|
If you want to just merge it as a starting point, I don't object. (I don't
think I reviewed all the original server test cases either)
…On Mon, Mar 4, 2024 at 1:42 PM William Woodruff ***@***.***> wrote:
I'm not going to have time to give this a proper review in the near-time
frame, not sure how you'd like to proceed.
No worries. I was thinking I could merge this as-is (since the existing
limbo harness upstream should skip them), but this can also sit until you
have more review time + I have the time to finish the actual client
implementation, which will probably be next week at the earliest 🙂
—
Reply to this email directly, view it on GitHub
<#196 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAAGBGNVY7B6TT2YOPENWDYWS6BRAVCNFSM6AAAAABDD3IY2KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNZXGIZDONJZHA>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
--
All that is necessary for evil to succeed is for good people to do nothing.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds two initial client verification testcases, both of which use email subjects and email NCs.