webpki: Authority Information Access tests #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tetsuo-cpp
commented
Oct 16, 2023
| @@ -421,4 +450,6 @@ def malformed_aia(builder: Builder) -> None: | |||
| ) | |||
|
|
|||
| builder = builder.server_validation() | |||
| builder.trusted_certs(root).peer_certificate(leaf).fails() | |||
| builder.trusted_certs(root).peer_certificate(leaf).expected_peer_name( | |||
| PeerName(kind="DNS", value="example.com") | |||
There was a problem hiding this comment.
This was previously failing because we don't check the subject, not because of the malformed AIA.
| @@ -395,6 +395,35 @@ def unicode_emoji_san(builder: Builder) -> None: | |||
| ).fails() | |||
|
|
|||
|
|
|||
| @testcase | |||
| def aia(builder: Builder) -> None: | |||
There was a problem hiding this comment.
I decided to add an extra test for the happy path when we have an AIA. On the pyca/cryptography side, I'm not doing much with this extension other than checking that it's well-formed.
woodruffw
approved these changes
Oct 16, 2023
|
Whoops, I may have merged this prematurely: I believe this should go under |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.