-
Notifications
You must be signed in to change notification settings - Fork 8
477 add princeton met forcing #524
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccarouge
commented
Jan 16, 2025
a960b32 to
4e2e238
Compare
SeanBryan51
requested changes
Mar 18, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requesting a few small changes but looks good overall
Removing redundant USE and IMPLICIT NONE statements Co-authored-by: Sean Bryan <39685865+SeanBryan51@users.noreply.github.com>
|
Requested changes added and tested. |
SeanBryan51
approved these changes
Mar 24, 2025
|
@SeanBryan51 FYI, while resolving the conflicts with main, I've noticed 2 unused statements (USE renamefiles). I've removed them and confirmed it compiles after the conflict resolution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CABLE
Thank you for submitting a pull request to the CABLE Project.
Description
Add the Princeton forcing as part of the changes brought by the groundwater work. The implementation follows the way it was initially done for the groundwater with the following differences:
Fixes #477
Type of change
Please delete options that are not relevant.
Checklist
Testing
When running with the Princeton forcing on for the year 1948, I have tested that the forcings output by CABLE are identical to the values in the input files. This is true except for the pressure and precipitation variables:
benchcab fluxsite tests return bitwise-comparable results with main, highlighting no side effects:
Please add a reviewer when ready for review.
📚 Documentation preview 📚: https://cable--524.org.readthedocs.build/en/524/