Skip to content

Conversation

@ccarouge
Copy link
Member

@ccarouge ccarouge commented Jan 13, 2025

CABLE

Thank you for submitting a pull request to the CABLE Project.

Description

Add the Princeton forcing as part of the changes brought by the groundwater work. The implementation follows the way it was initially done for the groundwater with the following differences:

  • adaptation to the refactoring of the driver
  • bug fixed in renameFiles_Princeton() (added the "BACK" keyword to INDEX() call) and modification in cable_input since Princeton does not provide a file for snowfall.

Fixes #477

Type of change

Please delete options that are not relevant.

  • New

Checklist

  • The new content is accessible and located in the appropriate section.
  • I have checked that links are valid and point to the intended content.
  • I have checked my code/text and corrected any misspellings

Testing

When running with the Princeton forcing on for the year 1948, I have tested that the forcings output by CABLE are identical to the values in the input files. This is true except for the pressure and precipitation variables:

  • pressure shows a small noise with a maximum difference of 0.008 Pa that is negligible. This is linked to the unit conversions between hPa and Pa.
  • precipitation shows a few grid cells with differences up to -4e-10 mm/s. This is negligible and likely due to the split between rain and snow precipitation.

benchcab fluxsite tests return bitwise-comparable results with main, highlighting no side effects:

2025-03-13 18:25:58,919 - INFO - benchcab.benchcab.py:381 - 0 failed, 168 passed

Please add a reviewer when ready for review.


📚 Documentation preview 📚: https://cable--524.org.readthedocs.build/en/524/

@ccarouge ccarouge force-pushed the 477-Add-Princeton-met-forcing branch from a960b32 to 4e2e238 Compare March 13, 2025 04:45
@ccarouge ccarouge marked this pull request as ready for review March 17, 2025 22:37
@ccarouge ccarouge requested a review from SeanBryan51 March 17, 2025 22:37
Copy link
Collaborator

@SeanBryan51 SeanBryan51 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting a few small changes but looks good overall

ccarouge and others added 3 commits March 19, 2025 14:42
Removing redundant USE and IMPLICIT NONE statements

Co-authored-by: Sean Bryan <39685865+SeanBryan51@users.noreply.github.com>
@ccarouge
Copy link
Member Author

Requested changes added and tested.

@ccarouge ccarouge requested a review from SeanBryan51 March 24, 2025 02:56
@ccarouge
Copy link
Member Author

@SeanBryan51 FYI, while resolving the conflicts with main, I've noticed 2 unused statements (USE renamefiles). I've removed them and confirmed it compiles after the conflict resolution.

@ccarouge ccarouge merged commit 6102496 into main Mar 25, 2025
6 of 7 checks passed
@ccarouge ccarouge deleted the 477-Add-Princeton-met-forcing branch March 25, 2025 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Princeton met forcing option for groundwater work

3 participants