Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new PV preview and modify the old PV related ICD test #17

Closed
acdo2002 opened this issue May 2, 2023 · 2 comments
Closed

Add new PV preview and modify the old PV related ICD test #17

acdo2002 opened this issue May 2, 2023 · 2 comments
Assignees
@acdo2002

Comments

@acdo2002
Copy link
Collaborator

acdo2002 commented May 2, 2023

the old PV related ICD tests may need to modify

need to add new PV preview tests because we have new protobuf message
@acdo2002 acdo2002 self-assigned this May 2, 2023
@acdo2002 acdo2002 mentioned this issue May 2, 2023
Merged
@acdo2002
Copy link
Collaborator Author

acdo2002 commented May 9, 2023 •
edited
Loading

  • Test design document
  • Implementation

@acdo2002
Copy link
Collaborator Author

@kswang1029
Here is the new tests for the PV preview.
There are 3 new ICD messages: PV_PREVIEW_DATA, STOP_PV_PREVIEW, and CLOSE_PV_PREVIEW
"PV_PREVIEW": testing three image types (fits, casa, and hdf5) and PV_PREVIEW_DATA could be part of PV_response or could be individual stream(already set a region and just move the region)
"PV_PREVIEW_CANCEL": testing STOP_PV_PREVIEW with different preview rebin in X and Y

@acdo2002 acdo2002 mentioned this issue Jul 13, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@acdo2002 acdo2002

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@acdo2002