block one test that regression problem in the backend PR1253 #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…view BackendService.ts
|
The pv preview frontend PR#2100 has updated the BackendService.ts. This PR also update the corresponding MessageController.ts, adding the PV preview related codes. |
ajm-ska
approved these changes
May 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#17 Because the carta-backend PR#1253 has a regression issue#1259. Thus I temporary block the comparison test between PV generated images from fits and hdf5.
After the issue#1259 has been solved, the blocked test lines can be re-open again.
Please merge this PR after carta-backend PR#1253 merging into the dev.