Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mylin/17 pv preview #30

Merged
merged 12 commits into from
Jul 18, 2023
Merged

Mylin/17 pv preview #30

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
ae794bc
Initilize PV_PREVIEW.test.ts
acdo2002 Jun 27, 2023
a932b13
Merge branch 'dev' into mylin/17-pv-preview
acdo2002 Jun 28, 2023
93cbeff
Merge branch 'dev' into mylin/17-pv-preview
acdo2002 Jul 3, 2023
28040c0
finish Step 4 in PV_PREVIEW.test.ts
acdo2002 Jul 4, 2023
497f415
step 5 of PV_PREVIEW.test.ts
acdo2002 Jul 5, 2023
dd2440a
step 6 in PV_PREVIEW.test.ts
acdo2002 Jul 5, 2023
4aa421d
finish Step 7 in PV_PREVIEW.test.ts
acdo2002 Jul 10, 2023
d99c649
add pvPreviewStream
acdo2002 Jul 11, 2023
cff3bb1
add specialsetRegion in MessageController.ts and finish step 8 in PV_…
acdo2002 Jul 12, 2023
9bd68f4
finish PV_PREVIEW.test.ts
acdo2002 Jul 12, 2023
d1747c3
add PV_PREVIEW_CANCEL.test.ts
acdo2002 Jul 13, 2023
f68e95c
finish PV_PREVIEW_CANCEL.test.ts
acdo2002 Jul 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions src/test/MessageController.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -524,6 +524,27 @@ export class MessageController {
return false;
}

spectialSetRegion(fileId: number, regionId: number, region: RegionStore, isRequestingPreview?: boolean): boolean {
if (this.connectionStatus === ConnectionStatus.ACTIVE) {
const message = CARTA.SetRegion.create({
fileId,
regionId,
regionInfo: {
regionType: region.regionType,
rotation: region.rotation,
controlPoints: region.controlPoints.slice()
},
previewRegion: isRequestingPreview
});
const requestId = this.eventCounter;
this.logEvent(CARTA.EventType.SET_REGION, requestId, message, false);
if (this.sendEvent(CARTA.EventType.SET_REGION, CARTA.SetRegion.encode(message).finish())) {
return true;
}
}
return false;
}

async setRegion(fileId: number, regionId: number, region: RegionStore, isRequestingPreview?: boolean): Promise<CARTA.ISetRegionAck> {
if (this.connectionStatus !== ConnectionStatus.ACTIVE) {
throw new Error("Not connected");
Expand Down
Loading