-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test to open images and file information #222
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works on Ubuntu.
I copied over the new /set_casaImageVarients
folder to the Mac, but unfortunately there is a problem with these new 'snapshot' files. For example,
- "date": "1575483289",
+ "date": "1618195790",
"name": "componentlist.image",
"size": "1880126",
- "date": "1575483289",
+ "date": "1618195859",
"name": "concatenated.image",
"size": "1134908779",
"entryType": "FLOAT",
"name": "OBSDEC",
- "numericValue": 13.277961108781836,
+ "numericValue": 13.277961108781838,
"value": "1.327796110878E+01",
Could it be that the image files on the Mac are different (older versions) compared the ones currently on almalustre?
If the header item is trivial, we might skip it. Such as the file 'date' of creation. |
and add a tolerance to precision digits
Now the only problem is the float number in
How accurate does it need to be? |
Suppose it's enough to set 4 digits here. |
it is better to use relative error and tolerance. |
How about verify its digits after transferring this float number to an exponential float number? |
So far testing with Ubuntu and MacOS, they works fine with ws. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good. Seems fine on Ubuntu and MacOS now.
For #165 and #221, to test requesting the information of files and opening the images.
OPEN_IMAGE_PV will test the image containing pv data.
OPEN_IMAGE_CASA_VARIENTS will test the variant casa images.
FILEINFO_CASA_VARIENTS will check out the file info in the variant casa images.
Use Jest.toMatchSnapshot() to see if the responding message is as exact as expected.