Rwjs/unique sids #1049
Merged
Rwjs/unique sids #1049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… that a pointer to an end-of-life session can be removed from the SessionManager session map.
Modefined the way that sessions get deleted to make sure they all get removed from the SessionManager session map.
Made change to session deletion so that it is consistent in both cases when a WebSocket closes and when the last OnMessageTask referencing a session is deleted.
from the SessionManager session map.
…ixed the id issue so the final fix needs to go somewere else, so very much a work in progress.
out that it behaves differently depending on what compiler settings are used with g++ v9.4.0.
veggiesaurus
requested changes
Mar 15, 2022
|
@robsimmonds does this mean we should close #1048 without merging? |
@angus I think that we should first merge #1048, then merge dev into this, then merge this. I'm just waiting for CI to come back. |
veggiesaurus
approved these changes
Mar 16, 2022
confluence
approved these changes
Mar 16, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create unique session ids even if reconnections are intermingled with new connections.
This builds on the session deletion PR from earlier today that I asked @confluence to review.