Yuhsuan/918 save restfreq #1088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YuHsuan-Hwang
requested review from
confluence,
pford,
markccchiang and
kswang1029
This was referenced Apr 15, 2022
kswang1029
approved these changes
Apr 18, 2022
There was a problem hiding this comment.
tested 👍 @confluence @pford @markccchiang please proceed code review.
markccchiang
approved these changes
Apr 18, 2022
pford
requested changes
Apr 18, 2022
This is updated. |
confluence
approved these changes
Apr 19, 2022
confluence
reviewed
Apr 19, 2022
pford
approved these changes
Apr 19, 2022
veggiesaurus
approved these changes
Apr 19, 2022
@confluence merged dev branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #918:
Set custom rest freq when saving files. The image is saved as
casacore::PagedImagewhen changing rest freq is required.Companion PRs:
CARTAvis/carta-frontend#1830
CARTAvis/carta-protobuf#69