Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PV preview feature #1253

Merged
merged 81 commits into from
May 3, 2023
Merged

PV preview feature #1253

merged 81 commits into from
May 3, 2023

Commits on Feb 8, 2023

  1. Update protobuf with latest pv preview changes

    @pford
    pford committed Feb 8, 2023
    Configuration menu
    Copy the full SHA
    d033b3c View commit details
    Browse the repository at this point in the history

  2. Update protobuf

    @pford
    pford committed Feb 8, 2023
    Configuration menu
    Copy the full SHA
    baa5f6b View commit details
    Browse the repository at this point in the history

  3. Update protobuf

    @pford
    pford committed Feb 8, 2023
    Configuration menu
    Copy the full SHA
    84afdb9 View commit details
    Browse the repository at this point in the history

  4. Add StopPvPreview message handling

    @pford
    pford committed Feb 8, 2023
    Configuration menu
    Copy the full SHA
    da445cf View commit details
    Browse the repository at this point in the history

Commits on Feb 21, 2023

  1. Handle PV preview messages

    @pford
    pford committed Feb 21, 2023
    Configuration menu
    Copy the full SHA
    b8054b6 View commit details
    Browse the repository at this point in the history

  2. Update protobuf to latest pv preview changes

    @pford
    pford committed Feb 21, 2023
    Configuration menu
    Copy the full SHA
    c79cbec View commit details
    Browse the repository at this point in the history

Commits on Feb 22, 2023

  1. Initial PV preview message handling (no downsampling)

    @pford
    pford committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    ce0e6e2 View commit details
    Browse the repository at this point in the history

  2. Set preview frame in map using preview id with offset

    @pford
    pford committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    ec8a668 View commit details
    Browse the repository at this point in the history

  3. Add temporary debug output for pv preview progress + response

    @pford
    pford committed Feb 22, 2023
    Configuration menu
    Copy the full SHA
    e5424c8 View commit details
    Browse the repository at this point in the history

Commits on Feb 27, 2023

  1. Update protobuf for pv preview data message

    @pford
    pford committed Feb 27, 2023
    Configuration menu
    Copy the full SHA
    c513313 View commit details
    Browse the repository at this point in the history

Commits on Mar 1, 2023

  1. Add structs for pv preview settings

    @pford
    pford committed Mar 1, 2023
    Configuration menu
    Copy the full SHA
    3a4a8d7 View commit details
    Browse the repository at this point in the history

Commits on Mar 2, 2023

  1. Update protobuf for new PvPreviewData fields

    @pford
    pford committed Mar 2, 2023
    Configuration menu
    Copy the full SHA
    5521d2a View commit details
    Browse the repository at this point in the history

Commits on Mar 4, 2023

  1. Refactor and fix pv preview request and update

    @pford
    pford committed Mar 4, 2023
    Configuration menu
    Copy the full SHA
    3c70e0b View commit details
    Browse the repository at this point in the history

  2. Remove debugging output

    @pford
    pford committed Mar 4, 2023
    Configuration menu
    Copy the full SHA
    2e16570 View commit details
    Browse the repository at this point in the history

Commits on Mar 9, 2023

  1. Remove debug output

    @pford
    pford committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    1d2d46b View commit details
    Browse the repository at this point in the history

  2. Add Frame methods to create SubImage from region or slicer

    @pford
    pford committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    1642c99 View commit details
    Browse the repository at this point in the history

  3. Update protobuf for SetRegion pv preview flag

    @pford
    pford committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    8ae34d6 View commit details
    Browse the repository at this point in the history

  4. Use class for preview cube

    @pford
    pford committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    6a19407 View commit details
    Browse the repository at this point in the history

  5. Refactor RegionHandler methods for pv preview updates

    @pford
    pford committed Mar 9, 2023
    Configuration menu
    Copy the full SHA
    137ecc0 View commit details
    Browse the repository at this point in the history

Commits on Mar 10, 2023

  1. Use input frame for pv calculations if no downsizing

    @pford
    pford committed Mar 10, 2023
    Configuration menu
    Copy the full SHA
    cf0807e View commit details
    Browse the repository at this point in the history

Commits on Mar 13, 2023

  1. Refactor line box regions for profiles to a separate class

    @pford
    pford committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    6ad548a View commit details
    Browse the repository at this point in the history

  2. Merge branch 'dev' into pam/795_pv_preview

    @pford
    pford committed Mar 13, 2023
    Configuration menu
    Copy the full SHA
    dd540c3 View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2023

  1. Add flag to Frame ctor to not load image cache for pv preview image

    @pford
    pford committed Mar 15, 2023
    Configuration menu
    Copy the full SHA
    a3c9ba6 View commit details
    Browse the repository at this point in the history

  2. Add performance logging for pv preview updates

    @pford
    pford committed Mar 15, 2023
    Configuration menu
    Copy the full SHA
    1f7e60e View commit details
    Browse the repository at this point in the history

  3. Calculate pv image profiles in PvPreviewCube

    @pford
    pford committed Mar 15, 2023
    Configuration menu
    Copy the full SHA
    cdc1a0a View commit details
    Browse the repository at this point in the history

Commits on Mar 22, 2023

  1. Refactor and bug fix 

    * Check for valid spectral coordinate in source image
* Pass RegionState for pv cut to update pv prevew
* Move MVDirection mutex to one place in LineBoxRegions
* Pass PvPreviewCut and PvPreviewCube instead of each param
    @pford
    pford committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    6cea3ef View commit details
    Browse the repository at this point in the history

  2. Assign filename to preview image: append _preview and id

    @pford
    pford committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    dd365d0 View commit details
    Browse the repository at this point in the history

  3. Convert stokes value to casacore for PV image 

    Move computed stokes code to new files
    @pford
    pford committed Mar 22, 2023
    Configuration menu
    Copy the full SHA
    62f08e9 View commit details
    Browse the repository at this point in the history

Commits on Mar 23, 2023

  1. Fix rebin bug and report preview cube data load performance

    @pford
    pford committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    e243bcd View commit details
    Browse the repository at this point in the history

  2. Set source image frame so can apply preview region

    @pford
    pford committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    d9e1b7e View commit details
    Browse the repository at this point in the history

  3. Fix refactoring bug

    @pford
    pford committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    64a7496 View commit details
    Browse the repository at this point in the history

  4. Set PV cut in rebinned preview image

    @pford
    pford committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    edf4c2e View commit details
    Browse the repository at this point in the history

Commits on Mar 27, 2023

  1. Normalize rebin to >= 1

    @pford
    pford committed Mar 27, 2023
    Configuration menu
    Copy the full SHA
    8d90f3e View commit details
    Browse the repository at this point in the history

  2. Merge branch 'dev' into pam/795_pv_preview

    @pford
    pford committed Mar 27, 2023
    Configuration menu
    Copy the full SHA
    3c1245f View commit details
    Browse the repository at this point in the history

  3. Set stop flag before updating preview cube

    @pford
    pford committed Mar 27, 2023
    Configuration menu
    Copy the full SHA
    a830beb View commit details
    Browse the repository at this point in the history

  4. Implement loading rebinned preview cube data

    @pford
    pford committed Mar 27, 2023
    Configuration menu
    Copy the full SHA
    eb986bd View commit details
    Browse the repository at this point in the history

Commits on Mar 31, 2023

  1. Remove repeated code

    @pford
    pford committed Mar 31, 2023
    Configuration menu
    Copy the full SHA
    65581ca View commit details
    Browse the repository at this point in the history

  2. Merge branch 'dev' into pam/795_pv_preview

    @pford
    pford committed Mar 31, 2023
    Configuration menu
    Copy the full SHA
    f420810 View commit details
    Browse the repository at this point in the history

Commits on Apr 6, 2023

  1. Fix rebin_z bug in calculating preview cube data

    @pford
    pford committed Apr 6, 2023
    Configuration menu
    Copy the full SHA
    b8a549a View commit details
    Browse the repository at this point in the history

  2. Fix pv preview rebin_xy: do not load image cache in FileLoader 

    Data is calculated and stored in PvPreviewCube
    @pford
    pford committed Apr 6, 2023
    Configuration menu
    Copy the full SHA
    3c4452c View commit details
    Browse the repository at this point in the history

Commits on Apr 10, 2023

  1. Fix build warnings on macos

    @pford
    pford authored and Pam Harris committed Apr 10, 2023
    Configuration menu
    Copy the full SHA
    cd2b37b View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2023

  1. Add pv preview settings mutex and fix cancel crash

    @pford
    pford committed Apr 12, 2023
    Configuration menu
    Copy the full SHA
    dd4ea4a View commit details
    Browse the repository at this point in the history

  2. Merge branch 'dev' into pam/795_pv_preview

    @pford
    pford committed Apr 12, 2023
    Configuration menu
    Copy the full SHA
    a7833bd View commit details
    Browse the repository at this point in the history

  3. Fix point region spatial profile

    @pford
    pford committed Apr 12, 2023
    Configuration menu
    Copy the full SHA
    b6fc1cc View commit details
    Browse the repository at this point in the history

Commits on Apr 13, 2023

  1. Update protobuf for pv preview histogram

    @pford
    pford committed Apr 13, 2023
    Configuration menu
    Copy the full SHA
    9c628aa View commit details
    Browse the repository at this point in the history

  2. Add Histogram to PvPreviewData for response and when not preview region

    @pford
    pford committed Apr 13, 2023
    Configuration menu
    Copy the full SHA
    cc96fc3 View commit details
    Browse the repository at this point in the history

  3. Add progress updates to pv preview cube data loading

    @pford
    pford committed Apr 13, 2023
    Configuration menu
    Copy the full SHA
    91ca719 View commit details
    Browse the repository at this point in the history

  4. Fix AxisRange ==

    @pford
    pford committed Apr 13, 2023
    Configuration menu
    Copy the full SHA
    6356605 View commit details
    Browse the repository at this point in the history

  5. Use spectral axis for nchan in pv preview profiles

    @pford
    pford committed Apr 13, 2023
    Configuration menu
    Copy the full SHA
    26ea03f View commit details
    Browse the repository at this point in the history

Commits on Apr 14, 2023

  1. Remove debug output

    @pford
    pford committed Apr 14, 2023
    Configuration menu
    Copy the full SHA
    f83a52c View commit details
    Browse the repository at this point in the history

  2. Fix overflow error

    @pford
    pford committed Apr 14, 2023
    Configuration menu
    Copy the full SHA
    40bc842 View commit details
    Browse the repository at this point in the history

Commits on Apr 18, 2023

  1. Add concurrent_queue size()

    @pford
    pford committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    2637d46 View commit details
    Browse the repository at this point in the history

  2. Remove debug output

    @pford
    pford committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    69083e1 View commit details
    Browse the repository at this point in the history

  3. Add flag for reporting performance in Frame GetRegionData 

    Reduce output in PV preview calculation
    @pford
    pford committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    3bd1b45 View commit details
    Browse the repository at this point in the history

  4. Add mutexes for concurrent pv preview and line spatial profiles 

    Fix crashes due to coord sys copy and MVDirection separation
    @pford
    pford committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    8b7ade8 View commit details
    Browse the repository at this point in the history

  5. Change class member names to follow convention

    @pford
    pford committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    ddd4cb7 View commit details
    Browse the repository at this point in the history

  6. Use bounding box parameter instead of LCRegion to unlock earlier

    @pford
    pford committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    68a9810 View commit details
    Browse the repository at this point in the history

  7. Support pv preview data compression

    @pford
    pford committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    f490f9d View commit details
    Browse the repository at this point in the history

  8. Add PvPreviewUpdateTask to message tasks 

    Queue the update task after setting region in PvPreviewCut
    @pford
    pford committed Apr 18, 2023
    Configuration menu
    Copy the full SHA
    fed4843 View commit details
    Browse the repository at this point in the history

Commits on Apr 20, 2023

  1. Implement pv preview compression quality settings

    @pford
    pford committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    bcac96d View commit details
    Browse the repository at this point in the history

  2. Only use PvPreviewCube stop flag when loading data

    @pford
    pford committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    89da231 View commit details
    Browse the repository at this point in the history

  3. Load pv preview cube data when asked for preview image

    @pford
    pford committed Apr 20, 2023
    Configuration menu
    Copy the full SHA
    89f3dae View commit details
    Browse the repository at this point in the history

Commits on Apr 21, 2023

  1. Use save/restore instead of copy SpectralCoordinate

    @pford
    pford committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    9530aef View commit details
    Browse the repository at this point in the history

  2. Load cube data when getting preview cube image

    @pford
    pford committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    555fdaa View commit details
    Browse the repository at this point in the history

  3. Stop pv preview updates (clear region queue) if user restarts

    @pford
    pford committed Apr 21, 2023
    Configuration menu
    Copy the full SHA
    6d1020a View commit details
    Browse the repository at this point in the history

Commits on Apr 25, 2023

  1. Move RegionHandler region mutex to include id 

    Temp regions being assigned same id
    @pford
    pford committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    9f5f90a View commit details
    Browse the repository at this point in the history

  2. Revert to copying SpectralCoordinate for pv preview image

    @pford
    pford committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    536282d View commit details
    Browse the repository at this point in the history

  3. Cancel pv preview region queue when close preview window

    @pford
    pford committed Apr 25, 2023
    Configuration menu
    Copy the full SHA
    f588edc View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2023

  1. Fix CPE in RegionHandler, lock region mutex for id and new region

    @pford
    pford committed Apr 26, 2023
    Configuration menu
    Copy the full SHA
    163cad1 View commit details
    Browse the repository at this point in the history

  2. Construct pv image spectral coord instead of copy

    @pford
    pford committed Apr 26, 2023
    Configuration menu
    Copy the full SHA
    e020072 View commit details
    Browse the repository at this point in the history

  3. Use shared_ptr reference in PvGenerator

    @pford
    pford committed Apr 26, 2023
    Configuration menu
    Copy the full SHA
    6de7e51 View commit details
    Browse the repository at this point in the history

  4. Remove unused PvGenerator method

    @pford
    pford committed Apr 26, 2023
    Configuration menu
    Copy the full SHA
    2070b46 View commit details
    Browse the repository at this point in the history

  5. Fix format

    @pford
    pford committed Apr 26, 2023
    Configuration menu
    Copy the full SHA
    6ea882e View commit details
    Browse the repository at this point in the history

  6. Remove pv preview line box region if lcregion fails

    @pford
    pford committed Apr 26, 2023
    Configuration menu
    Copy the full SHA
    539122f View commit details
    Browse the repository at this point in the history

  7. Remove RegionHandler unused map

    @pford
    pford committed Apr 26, 2023
    Configuration menu
    Copy the full SHA
    4e3531e View commit details
    Browse the repository at this point in the history

  8. Remove pv cut region in preview cube if cancel or error

    @pford
    pford committed Apr 26, 2023
    Configuration menu
    Copy the full SHA
    64304d8 View commit details
    Browse the repository at this point in the history

Commits on Apr 28, 2023

  1. Merge branch 'dev' into pam/795_pv_preview

    @pford
    pford committed Apr 28, 2023
    Configuration menu
    Copy the full SHA
    cd96568 View commit details
    Browse the repository at this point in the history

  2. Update protobuf to latest branch commit (doc changes only)

    @pford
    pford committed Apr 28, 2023
    Configuration menu
    Copy the full SHA
    4b74369 View commit details
    Browse the repository at this point in the history

Commits on May 3, 2023

  1. bump protobuf version

    @confluence
    confluence committed May 3, 2023
    Configuration menu
    Copy the full SHA
    05a26ff View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/dev' into pam/795_pv_preview

    @confluence
    confluence committed May 3, 2023
    Configuration menu
    Copy the full SHA
    fbcb6ea View commit details
    Browse the repository at this point in the history

  3. Fixed use of histogram function after merge

    @confluence
    confluence committed May 3, 2023
    Configuration menu
    Copy the full SHA
    4e3e330 View commit details
    Browse the repository at this point in the history