-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support channel map for range of channels #1356
Draft
pford
wants to merge
33
commits into
dev
Choose a base branch
from
pam/1186_channel_map
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ignores channel field when range is set
pford
added
the
requiring frontend
this backend issue requires work in both frontend and backend
label
Jan 30, 2024
…end into pam/1186_channel_map
…end into pam/1186_channel_map
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Draft PR pending frontend support for testing.
Implements channel map view (backend) #1186
Using the channel_range added to SetImageChannels message, backend sends the requested tiles for the requested channels. The downsampled data for each channel is retrieved to create the tiles but is not stored. (TODO: check tile cache)
channel map view (frontend) carta-frontend#1203 (issue), Add fields and message for channel map carta-protobuf#92
Select channel map view, should be shown a grid of images with consecutive channels.
Checklist
no changelog update neededno protobuf update neededprotobuf version bumped/ protobuf version not bumped