Mylin/1617 support spatial profile line polyline #1812

acdo2002 · 2022-03-25T09:07:47Z

Fixed #1617
The corresponding backend PR1020

… RegionSelectorComponent.tsx

kswang1029 · 2022-04-14T09:54:49Z

I have had a preview of this branch and found few issues that need to be addressed:

when the region is point or cursor, the x label of the profile plot is "X coordinate" or "Y coordinate" (with an implicit unit of "pixel". When the region is line (not polyline), the x label should be revised to offset with a unit (eg Offset (arcsec). The actual unit (arcsec, arcmin, or degree) is determined by the angular size of the line region and the backend should already have a handle on this based on the implementation of pv generator. When the region is polyline, the x label should be "Distance" with a unit. I suspect we need to update protobuf message SPATIAL_PROFILE_DATA.
If we update the line or polyline region and before the new results come in, we need to have visual indication that the backend is working on it. Similar to region spectral profilers, we should set the old profile dimmer.
the red vertical line should disappear when the region type is line and polyline. (as a future enhancement, we should display a marker along the line or polyline region and sync its movement with the red vertical line in the spatial profile plot)
if the active line region is deleted, the spatial profiler has an odd behavior displaying the new active region.

Screen.Recording.2022-04-14.at.17.59.02.mov

the title of the spatial profiler widget should be more dynamic based on what is being displayed. Before the support of line and polyline region, it is like "X Profile: Cursor". Now this should be like "Profile: region 2" when region 2 is a line region or a polyline region.
some UI elements in the smoothing tab of the settings dialog are not rendered properly.

…ne region in export data header

kswang1029 · 2022-04-26T14:53:46Z

@TienHao as we have a new “compute” tab in the settings dialog, please add a placeholder for the in-app help.

kswang1029 · 2022-04-27T03:44:53Z

@TienHao Please help to refine the cursor info:

when the region is line or polyline, we don't need to show world coordinate in the cursor info
please switch to scientific notation to show distance or offset. %.5e should be good enough.
Replace "Image" to "Offset" (for line region) or "Distance" (for polyline region).

kswang1029 · 2022-04-27T03:57:12Z

@TienHao The tsv header and file name need another tweak. When the profile is from line or polyline region, we should say "Region Profile" instead of "X profile" in the first line of the tsv file. Similar for the file name of the tsv.

kswang1029 · 2022-04-27T04:46:50Z

@TienHao please enable auto y-scale when zooming for a line or polyline profile, just like point or cursor region profile.

kswang1029 · 2022-04-27T05:28:48Z

@TienHao The title of the settings dialog needs a tweak too. I suggest we unify it to "Spatial Profile Settings"

In addition, the show mean/rms function does not work for line/polyline profile.

* refined cursor info * modified exportData header and title of settings dialog * enable auto y-scale zooming * fixed Mean/RMS

…ocal decimated profile

kswang1029 · 2022-04-29T09:55:45Z

@YuHsuan-Hwang @veggiesaurus I have had brief tests during the draft PR stage. Now it is ready for code review. I will continue my tests before approving.

kswang1029

@TienHao @acdo2002 this works nicely. 👍

YuHsuan-Hwang

The changes look good to me. only very minor issues.

src/components/SpatialProfiler/SpatialProfilerComponent.tsx

src/stores/Frame/RegionStore.ts

acdo2002 · 2022-05-06T13:52:43Z

@YuHsuan-Hwang I try my best to solve the merge conflicts (as well as solve the minor issue you suggested), could you check whether this branch is working fine or not?
At least this branch can build successfully on my MacOS 11 laptop, I will try to build on my Ubuntu laptop in the weekend.

YuHsuan-Hwang

@YuHsuan-Hwang I try my best to solve the merge conflicts (as well as solve the minor issue you suggested), could you check whether this branch is working fine or not?
At least this branch can build successfully on my MacOS 11 laptop, I will try to build on my Ubuntu laptop in the weekend.

@acdo2002 looks fine to me 👍

acdo2002 · 2022-05-09T06:04:15Z

I have tried to build it on ubuntu 20.04, it looks fine.

acdo2002 and others added 27 commits March 2, 2022 14:17

match pam's protobuf

783cf25

set width to SpatialProfileWidgetStore.ts

1c1a16c

remove the block line region in dropdown Region

f691937

feed xMax and x value to plotData

45a0441

remove case RegionsType.CLOSED & case RegionsType.CLOSED_AND_POINT in…

d80a78b

… RegionSelectorComponent.tsx

add LineRegionSampleWidth in SpatialProfileWidgetStore.ts

17ed73e

plot line region & without x wcs coordinate

233efa4

add computation tab

aa855c4

Merge branch 'dev' into mylin/1617-support_spatial_profile_line_polyline

aac083d

remove import CARTA

8b6befb

add width

51115b8

define bp3-input scss

e094b1e

attach the line region plotdata

fc58d54

Match Pam's protobuf

fd58d8e

Merge branch 'dev' into mylin/1617-support_spatial_profile_line_polyline

ce5db2c

Merge branch 'dev' into mylin/1617-support_spatial_profile_line_polyline

e9c55b0

refactory SpatialProfileWidgetStore.ts

7a0490a

add Region.Type POLYLINE

36d1a59

reformat

dc1d514

resolve merge conflict in RegionSelectorComponent.tsx

6073306

Merge branch 'dev' into mylin/1617-support_spatial_profile_line_polyline

040a821

remove xMin and modify x

7b0972f

fix the xMin and xMax for line/polyline region

c22bafe

fix polyline show top Axis

eecb639

Merge branch 'dev' into mylin/1617-support_spatial_profile_line_polyline

fad2811

Merge branch 'dev' into mylin/1617-support_spatial_profile_line_polyline

a6fd45b

Merge branch 'dev' into mylin/1617-support_spatial_profile_line_polyline

5366bd6

ming-yi and others added 2 commits April 14, 2022 21:00

fixed bp3-input width in SpatialProfilerSettingsPanelComponent.scss

d11c3b5

add opacity condition to cursorX marker

ac86c0e

TienHao added 2 commits April 26, 2022 16:51

fixed smoothing profile of line and polyline regions

72b9f6a

fixed line region delete bug, and modified region data of line/polyli…

ee261b1

…ne region in export data header

TienHao added 4 commits April 28, 2022 13:58

code refactoring

273b951

added help content, fixed bugs

716d1d4

* refined cursor info * modified exportData header and title of settings dialog * enable auto y-scale zooming * fixed Mean/RMS

Merge branch 'dev' into mylin/1617-support_spatial_profile_line_polyline

1714f02

removed wcs data in cursor info of line/polyline regions, and fixed l…

c9ddfb8

…ocal decimated profile

TienHao marked this pull request as ready for review April 29, 2022 09:47

kswang1029 requested review from YuHsuan-Hwang and veggiesaurus April 29, 2022 09:54

kswang1029 assigned YuHsuan-Hwang Apr 29, 2022

kswang1029 self-requested a review April 29, 2022 09:54

kswang1029 approved these changes May 3, 2022

View reviewed changes

YuHsuan-Hwang requested changes May 6, 2022

View reviewed changes

src/components/SpatialProfiler/SpatialProfilerComponent.tsx Outdated Show resolved Hide resolved

src/stores/Frame/RegionStore.ts Outdated Show resolved Hide resolved

src/stores/Frame/RegionStore.ts Outdated Show resolved Hide resolved

ming-yi added 4 commits May 6, 2022 20:37

fixed minor issue

bde1481

npm run reformat for RegionStore.ts

a9a37f9

update protobuf

5a66ac9

Match to Pam's protobuf

a423bdb

YuHsuan-Hwang approved these changes May 6, 2022

View reviewed changes

ming-yi and others added 2 commits May 10, 2022 01:42

update Pam's line profile protobuf

810f5bb

updated protobuf commit

0e080e0

veggiesaurus merged commit 27a932e into dev May 10, 2022

veggiesaurus deleted the mylin/1617-support_spatial_profile_line_polyline branch May 10, 2022 17:03

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Mylin/1617 support spatial profile line polyline #1812

Mylin/1617 support spatial profile line polyline #1812

acdo2002 commented Mar 25, 2022

kswang1029 commented Apr 14, 2022 •

edited

Loading

kswang1029 commented Apr 26, 2022

kswang1029 commented Apr 27, 2022 •

edited

Loading

kswang1029 commented Apr 27, 2022 •

edited

Loading

kswang1029 commented Apr 27, 2022

kswang1029 commented Apr 27, 2022 •

edited

Loading

kswang1029 commented Apr 29, 2022

kswang1029 left a comment

YuHsuan-Hwang left a comment

acdo2002 commented May 6, 2022

YuHsuan-Hwang left a comment

acdo2002 commented May 9, 2022

Mylin/1617 support spatial profile line polyline #1812

Mylin/1617 support spatial profile line polyline #1812

Conversation

acdo2002 commented Mar 25, 2022

kswang1029 commented Apr 14, 2022 • edited Loading

kswang1029 commented Apr 26, 2022

kswang1029 commented Apr 27, 2022 • edited Loading

kswang1029 commented Apr 27, 2022 • edited Loading

kswang1029 commented Apr 27, 2022

kswang1029 commented Apr 27, 2022 • edited Loading

kswang1029 commented Apr 29, 2022

kswang1029 left a comment

Choose a reason for hiding this comment

YuHsuan-Hwang left a comment

Choose a reason for hiding this comment

acdo2002 commented May 6, 2022

YuHsuan-Hwang left a comment

Choose a reason for hiding this comment

acdo2002 commented May 9, 2022

kswang1029 commented Apr 14, 2022 •

edited

Loading

kswang1029 commented Apr 27, 2022 •

edited

Loading

kswang1029 commented Apr 27, 2022 •

edited

Loading

kswang1029 commented Apr 27, 2022 •

edited

Loading