Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ksw/convert fitting Gaussian fwhm to semi-axes to render ellipse region #2214

Merged
merged 1 commit into from
Jul 31, 2023

Conversation

kswang1029
Copy link
Collaborator

@kswang1029 kswang1029 commented Jul 26, 2023

Description
This is to fix #2212. The root cause is the ellipse region takes semi-axes length to define the size. So we need to convert the fitted Gaussian FHWM by multiplying 0.5.

Checklist

For linked issues (if there are):

  • assignee and label added
  • ZenHub issue connection, board status, and estimate updated

For the pull request:

  • reviewers and assignee added
  • ZenHub estimate, milestone, and release (if needed) added
  • e2e test passing / corresponding fix added
  • changelog updated / no changelog update needed
  • protobuf updated to the latest dev commit / no protobuf update needed
  • BackendService unchanged / BackendService changed and corresponding ICD test fix added

Copy link
Collaborator

@YuHsuan-Hwang YuHsuan-Hwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, should be half of the size. Thanks for fixing this!

@YuHsuan-Hwang YuHsuan-Hwang merged commit 8211a00 into dev Jul 31, 2023
8 checks passed
@YuHsuan-Hwang YuHsuan-Hwang deleted the ksw/imfit_ellipse_render branch July 31, 2023 04:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ellipse regions from image fitting results are twice big
2 participants