-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Carli/1988 giant file jigsaw error #2219
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work. 👍
I believe that it also resolved issue #2026, but further testing is required to confirm that. @YuHsuan-Hwang |
Let's first close 1988 for now then. |
Description
This pr fixes #1988. Associated backend PR is #1288. The pendingSynchronisedTiles map in the TileService failed to clean up itself with each render, causing messy tiles to be rendered during panning and zooming. Also, syncId and tileCount are added to the RasterSyncMessage because there was not any robust method to determine whether the required tiles in a sync group have been transmitted, causing missing tiles during animation. Lastly, the pr fixed the blinking of the vector overlay during animation due to racing condition that caused image rendering before all the vector overlay tiles have been transmitted.
Checklist
For linked issues (if there are):
For the pull request:
corresponding fix addedno changelog update neededno protobuf update neededBackendService
unchanged /BackendService
changed and corresponding ICD test fix added