-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Yuhsuan/react 18 upgrade #2426
Open
YuHsuan-Hwang
wants to merge
14
commits into
dev
Choose a base branch
from
yuhsuan/react_18_upgrade
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Yuhsuan/react 18 upgrade #2426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ct-split-pane type def
Updates:
Update: we could consider replacing |
YuHsuan-Hwang
added
awaiting code review
For pull requests that require code review
awaiting testing
For pull requests that require testing
labels
Nov 4, 2024
veggiesaurus
approved these changes
Nov 5, 2024
nice work @YuHsuan-Hwang 😎 🚀 |
Note: Let's close #1974 after this PR is merged. |
loveluthien
approved these changes
Nov 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good on Mac and Ubuntu.
Filed #2433 for the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
awaiting code review
For pull requests that require code review
awaiting testing
For pull requests that require testing
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Patches
golden-layout
and upgrades to react 18.Also
react-color
type def (somehow does not work with react 18 type def)react-split-pane
type def (ref)react-konva
for react 18 compatibilitychildren
to react component props type (ref)Note that there is a warning from
react-resize-detector
. Investigated if it can be fixed by upgrading the package to v11, but found that the child function pattern<ReactResizeDetector/>
is removed from v10. Only theuseResizeDetector
hook is supported, which can only applied with functional components.This can be solved by creating a wrapper component, but requires additional changes because it adds an extra div element which breaks the current structure.I suggest we work on the upgrade in a separate PR (perhaps the next dev cycle) and focus ongolden-layout
patching and react 18 upgrade in this branch.Update: we could consider replacing
react-resize-detector
with blueprint<ResizeSensor/>
+ throttling.Let's close #1974 after this PR is merged.
Checklist
For linked issues (if there are):assignee and label addedGitHub Project estimate addedFor the pull request:
changelog updated/ no changelog update neededunit test added (for functions with no dependenies)API documentation added (for public variables and methods in stores)For dependencies:
protobuf version bumped/ no protobuf version bumped neededprotobuf updated to the latest dev commit/ no protobuf update neededcorresponding ICD test fix added (/ no ICD test fix needed (BackendService
changed)BackendService
unchanged)user manual prepared (for large new features)