Skip to content

Commit

Permalink
fix test and commit spotless
Browse files Browse the repository at this point in the history
  • Loading branch information
leonliu288 committed Dec 6, 2023
1 parent cddbe63 commit 600477d
Show file tree
Hide file tree
Showing 50 changed files with 133 additions and 66 deletions.
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
/* (C)2023 */
package com.cas.challengeservice.config;

import static com.cas.challengeservice.constant.Constants.MQ_REQUEST_ADD_BADGE;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
/* (C)2023 */
package com.cas.challengeservice.config;

import org.springframework.amqp.core.Binding;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
/* (C)2023 */
package com.cas.challengeservice.constant;

public class Constants {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
/* (C)2023 */
package com.cas.challengeservice.controller;

import com.cas.challengeservice.dto.*;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
/* (C)2023 */
package com.cas.challengeservice.controller;

import com.cas.challengeservice.dto.*;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
/* (C)2023 */
package com.cas.challengeservice.dto;

import lombok.*;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
/* (C)2023 */
package com.cas.challengeservice.dto;

import lombok.*;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
/* (C)2023 */
package com.cas.challengeservice.dto;

import lombok.*;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
/* (C)2023 */
package com.cas.challengeservice.dto;

import lombok.*;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
/* (C)2023 */
package com.cas.challengeservice.dto;

import lombok.*;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
/* (C)2023 */
package com.cas.challengeservice.dto;

import lombok.*;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
/* (C)2023 */
package com.cas.challengeservice.dto;

import lombok.*;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
/* (C)2023 */
package com.cas.challengeservice.dto;

import lombok.*;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
/* (C)2023 */
package com.cas.challengeservice.dto;

import jakarta.annotation.Nullable;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
/* (C)2023 */
package com.cas.challengeservice.dto;

import jakarta.annotation.Nullable;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
/* (C)2023 */
package com.cas.challengeservice.entity;

import com.cas.challengeservice.dto.BadgeDto;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
/* (C)2023 */
package com.cas.challengeservice.entity;

import com.cas.challengeservice.dto.ChallengeTypeDto;
import jakarta.persistence.*;
import jdk.jshell.Snippet;
import lombok.*;

@Data
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
/* (C)2023 */
package com.cas.challengeservice.repository;

import com.cas.challengeservice.entity.Badge;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
/* (C)2023 */
package com.cas.challengeservice.repository;

import com.cas.challengeservice.entity.ChallengeType;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
/* (C)2023 */
package com.cas.challengeservice.service;

import com.cas.challengeservice.dto.*;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
/* (C)2023 */
package com.cas.challengeservice.service;

import com.cas.challengeservice.dto.*;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
/* (C)2023 */
package com.cas.challengeservice.service.Impl;

import com.cas.challengeservice.dto.*;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
/* (C)2023 */
package com.cas.challengeservice.service.Impl;

import com.cas.challengeservice.dto.*;
Expand All @@ -14,6 +15,7 @@
@Log4j2
public class ChallengeServiceImpl implements ChallengeService {
private final ChallengeTypeRepository challengeTypeRepository;

@Autowired
public ChallengeServiceImpl(ChallengeTypeRepository challengeTypeRepository) {
this.challengeTypeRepository = challengeTypeRepository;
Expand Down Expand Up @@ -43,7 +45,9 @@ public GenericMessage<ChallengeTypeDto> getChallenge(ChallengeGetRequest request
} else {
return GenericMessage.<ChallengeTypeDto>builder()
.status(HttpStatus.UNAUTHORIZED)
.message("GetChallenge failed, user heart rate not in range for this challenge type")
.message(
"GetChallenge failed, user heart rate not in range for this"
+ " challenge type")
.build();
}
} else {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
/* (C)2023 */
package com.cas.challengeservice.service.Impl;

import com.cas.challengeservice.service.MessageService;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
/* (C)2023 */
package com.cas.challengeservice.service;

public interface MessageService {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
/* (C)2023 */
package com.cas.challengeservice;

import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.mockito.ArgumentMatchers.any;
import static org.mockito.Mockito.*;
Expand All @@ -13,6 +15,7 @@
import org.springframework.boot.test.context.SpringBootTest;
import org.springframework.http.HttpStatus;
import org.springframework.http.ResponseEntity;

@SpringBootTest
public class ChallengeControllerTests {
@Mock private ChallengeService challengeService;
Expand All @@ -32,11 +35,21 @@ public void setUp() {
type = "Balance";
exerciseCount = 30L;

challengeGetRequest = ChallengeGetRequest.builder().userHeartRate(userHeartRate).type(type).build();
challengeAddRequest = ChallengeAddRequest.builder().userHeartRate(userHeartRate).exerciseCount(exerciseCount).type(type).build();
challengeGetRequest =
ChallengeGetRequest.builder().userHeartRate(userHeartRate).type(type).build();
challengeAddRequest =
ChallengeAddRequest.builder()
.userHeartRate(userHeartRate)
.exerciseCount(exerciseCount)
.type(type)
.build();
challengeDeleteRequest = ChallengeDeleteRequest.builder().type(type).build();

message = GenericMessage.<ChallengeTypeDto>builder().status(HttpStatus.OK).message("Challenge Response").build();
message =
GenericMessage.<ChallengeTypeDto>builder()
.status(HttpStatus.OK)
.message("Challenge Response")
.build();
}

@Test
Expand Down
Original file line number Diff line number Diff line change
@@ -1,33 +1,32 @@
/* (C)2023 */
package com.cas.challengeservice;

import static org.junit.jupiter.api.Assertions.*;
import static org.mockito.Mockito.*;

import com.cas.challengeservice.dto.*;
import com.cas.challengeservice.entity.ChallengeType;
import com.cas.challengeservice.repository.ChallengeTypeRepository;
import com.cas.challengeservice.service.*;

import com.cas.challengeservice.service.Impl.ChallengeServiceImpl;
import java.util.Optional;
import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Test;
import org.mockito.InjectMocks;
import org.mockito.Mock;
import org.springframework.boot.test.context.SpringBootTest;
import org.springframework.http.HttpStatus;

import java.util.Optional;

import static org.junit.jupiter.api.Assertions.*;
import static org.mockito.Mockito.*;
@SpringBootTest
public class ChallengeServiceTests {
@Mock private ChallengeTypeRepository challengeTypeRepository;
@InjectMocks private ChallengeServiceImpl challengeServiceImpl;
@InjectMocks private ChallengeServiceImpl challengeServiceImpl;
private ChallengeAddRequest challengeAddRequest;
private ChallengeDeleteRequest challengeDeleteRequest;
private ChallengeGetRequest challengeGetRequest;

@BeforeEach
public void setUp() {
}
public void setUp() {}

@Test
public void testGetChallengeWhenChallengeTypeNotExist() {
Expand All @@ -37,29 +36,36 @@ public void testGetChallengeWhenChallengeTypeNotExist() {
GenericMessage<ChallengeTypeDto> result = challengeServiceImpl.getChallenge(request);

assertEquals(HttpStatus.NOT_FOUND, result.getStatus());
assertEquals("GetChallenge failed, no challenge type found with this type", result.getMessage());
assertEquals(
"GetChallenge failed, no challenge type found with this type", result.getMessage());
}

@Test
public void testGetChallengeWhenUserHeartRateNotInRange() {
ChallengeGetRequest request = new ChallengeGetRequest(300L, "Muscle");

ChallengeType challengeType = ChallengeType.builder().description("Muscle").userHeartRate(200L).build();
ChallengeType challengeType =
ChallengeType.builder().description("Muscle").userHeartRate(200L).build();

when(challengeTypeRepository.findByDescription(any())).thenReturn(Optional.ofNullable(challengeType));
when(challengeTypeRepository.findByDescription(any()))
.thenReturn(Optional.ofNullable(challengeType));

GenericMessage<ChallengeTypeDto> result = challengeServiceImpl.getChallenge(request);

assertEquals(HttpStatus.UNAUTHORIZED, result.getStatus());
assertEquals("GetChallenge failed, user heart rate not in range for this challenge type", result.getMessage());
assertEquals(
"GetChallenge failed, user heart rate not in range for this challenge type",
result.getMessage());
}

@Test
public void testGetChallengeSuccess() {
ChallengeType challengeType = ChallengeType.builder().description("Cardio").userHeartRate(120L).build();
ChallengeType challengeType =
ChallengeType.builder().description("Cardio").userHeartRate(120L).build();
ChallengeGetRequest request = new ChallengeGetRequest(120L, "Cardio");

when(challengeTypeRepository.findByDescription(any())).thenReturn(Optional.ofNullable(challengeType));
when(challengeTypeRepository.findByDescription(any()))
.thenReturn(Optional.ofNullable(challengeType));

GenericMessage<ChallengeTypeDto> result = challengeServiceImpl.getChallenge(request);

Expand All @@ -69,10 +75,12 @@ public void testGetChallengeSuccess() {

@Test
public void testAddChallengeTypeWhenChallengeTypeExist() {
ChallengeType challengeType = ChallengeType.builder().description("Cardio").userHeartRate(120L).build();
ChallengeType challengeType =
ChallengeType.builder().description("Cardio").userHeartRate(120L).build();
ChallengeAddRequest request = new ChallengeAddRequest(120L, 30L, "Cardio");

when(challengeTypeRepository.findByDescription(any())).thenReturn(Optional.ofNullable(challengeType));
when(challengeTypeRepository.findByDescription(any()))
.thenReturn(Optional.ofNullable(challengeType));

GenericMessage<ChallengeTypeDto> result = challengeServiceImpl.addChallenge(request);

Expand All @@ -99,14 +107,17 @@ public void testDeleteChallengeTypeWhenChallengeTypeNotFound() {
GenericMessage<ChallengeTypeDto> result = challengeServiceImpl.deleteChallenge(request);

assertEquals(HttpStatus.NOT_FOUND, result.getStatus());
assertEquals("DeleteChallenge failed, no challenge type found with this type", result.getMessage());
assertEquals(
"DeleteChallenge failed, no challenge type found with this type",
result.getMessage());
}

@Test
public void testDeleteChallengeTypeSuccess() {
ChallengeType challengeType = ChallengeType.builder().description("Flexibility").build();
ChallengeDeleteRequest request = new ChallengeDeleteRequest("Flexibility");
when(challengeTypeRepository.findByDescription(any())).thenReturn(Optional.ofNullable(challengeType));
when(challengeTypeRepository.findByDescription(any()))
.thenReturn(Optional.ofNullable(challengeType));

GenericMessage<ChallengeTypeDto> result = challengeServiceImpl.deleteChallenge(request);

Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
/* (C)2023 */
package com.cas.geoservice;

import org.springframework.boot.SpringApplication;
Expand All @@ -9,5 +10,4 @@ public class GeoServiceApplication {
public static void main(String[] args) {
SpringApplication.run(GeoServiceApplication.class, args);
}

}
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
/* (C)2023 */
package com.cas.geoservice.config;

import org.springframework.amqp.core.Binding;
Expand Down Expand Up @@ -34,8 +35,7 @@ public class RabbitMQConfig {
@Value("${spring.rabbitmq.queue}")
private String queueName;

@Autowired
private ZoneListener zoneListener;
@Autowired private ZoneListener zoneListener;

@Bean
public ConnectionFactory connectionFactory() {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,20 +1,20 @@
/* (C)2023 */
package com.cas.geoservice.config;

import static com.cas.geoservice.constant.Constants.MQ_REQUEST_SET_ZONE;

import com.cas.geoservice.dto.MessageDto;
import com.cas.geoservice.dto.PlayerSetZoneRequest;
import com.cas.geoservice.entity.PlayerZone;
import com.cas.geoservice.repository.PlayerZoneRepository;
import com.fasterxml.jackson.databind.ObjectMapper;
import java.util.Objects;
import lombok.extern.log4j.Log4j2;
import org.springframework.amqp.core.Message;
import org.springframework.amqp.core.MessageListener;
import org.springframework.beans.factory.annotation.Autowired;
import org.springframework.stereotype.Component;

import java.util.Objects;

import static com.cas.geoservice.constant.Constants.MQ_REQUEST_SET_ZONE;

@Component
@Log4j2
public class ZoneListener implements MessageListener {
Expand All @@ -40,14 +40,24 @@ public void onMessage(Message message) {
case MQ_REQUEST_SET_ZONE:
log.info("MQ - Set zone: {}", messageDto.getPlayerSetZoneRequest());
PlayerSetZoneRequest request = messageDto.getPlayerSetZoneRequest();
PlayerZone playerZone = PlayerZone.builder().username(request.getUsername()).name(request.getZone()).build();
PlayerZone playerZone =
PlayerZone.builder()
.username(request.getUsername())
.name(request.getZone())
.build();

PlayerZone zone = playerZoneRepository.findByUsername(request.getUsername());
if(Objects.isNull(zone)) {
log.info("Save player {} zone to : {}", playerZone.getUsername(), playerZone.getName());
if (Objects.isNull(zone)) {
log.info(
"Save player {} zone to : {}",
playerZone.getUsername(),
playerZone.getName());
playerZoneRepository.save(playerZone);
} else {
log.info("Update player {} zone to : {}", zone.getUsername(), zone.getName());
log.info(
"Update player {} zone to : {}",
zone.getUsername(),
zone.getName());
zone.setName(request.getZone());
playerZoneRepository.save(zone);
}
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
/* (C)2023 */
package com.cas.geoservice.constant;

public class Constants {
Expand Down
Loading

0 comments on commit 600477d

Please sign in to comment.