Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

import plink-ng as a git dependency #16

Closed
wants to merge 244 commits into from
Closed

import plink-ng as a git dependency #16

wants to merge 244 commits into from

Conversation

aryarm
Copy link
Member

@aryarm aryarm commented Mar 8, 2022

Compared to VCFs, PLINK files are a much more efficient format for storing and working with GWAS datasets. Reading from PLINK files takes seconds, while I've estimated that reading from VCFs can take half an hour for even the small datasets we want to work with. We'll eventually want to list the Python API for plink-ng (aka pgenlib) as a dependency of this tool, so that we can properly support reading and writing PLINK files. Currently our code just assumes this dependency is installed instead of installing it automatically via poetry.

Unfortunately, pgenlib has not yet been published to PyPi, so we'll have to install it directly from the Github repo in the subdirectory that it lives in. poetry-core added support for installing git packages from subdirectories in v1.1.0a7 (yesterday, on 3/5/22). So this PR adds pgenlib to the pyproject.toml file using the new syntax and updates poetry and poetry-core to support installing it.

@aryarm
Copy link
Member Author

aryarm commented Mar 10, 2022

Looks like the readthedocs build failed because python-poetry/poetry-core#288 hasn't been merged in yet. And we will eventually want python-poetry/poetry-core#300 and python-poetry/poetry#5172 .

The git url gets resolved to this

git+https://github.com/chrchang/plink-ng.git@v2.00a3-20220218#subdirectory2.0/Python

instead of this

git+https://github.com/chrchang/plink-ng.git@v2.00a3-20220218#subdirectory=2.0/Python

(notice the equal sign after #subdirectory?)

Update
It seems python-poetry/poetry-core#288 has been merged now. At this point, we just need to wait for the release of poetry-core v1.1.0b1 and its appearance on conda-forge.

Initial functionality for admixture simulator and visualization
@aryarm aryarm mentioned this pull request Jul 8, 2022
@aryarm
Copy link
Member Author

aryarm commented Jul 9, 2022

ok, I just rebased and updated the pyproject file to require 1.1.0b1

But the readthedocs build still failed

it looks like we'll still need python-poetry/poetry-core#300 in order to get this to work :(
for more details see python-poetry/poetry-core#300 (comment)

aryarm added a commit that referenced this pull request Jul 21, 2022
@aryarm
Copy link
Member Author

aryarm commented Jul 22, 2022

closing in favor of #68

@aryarm aryarm closed this Jul 22, 2022
@aryarm aryarm deleted the dep/update-poetry branch August 6, 2022 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants