Change AB mag calculation to interpolate passband to spectrum resolution #7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the AB magnitude calculation for a source's spectrum through a telescope's passbands.
Previously, we were interpolating the source spectrum to the passband's resolution. Instead, we should probably be interpolating the passband response curve to the source spectrum's resolution. There are two main reasons why I think we should do it this way.
If this rationale sounds right to you, @tewoods, and the changes to
spectrum.py
look alright, then you can approve these changes and I can merge this PR with the master branch.