Clean up dependencies #1248
Merged
Clean up dependencies #1248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cheehongw
force-pushed
the
clean-up-deps
branch
2 times, most recently
from
b347eac
to
65f638e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #1248 +/- ##
==========================================
+ Coverage 54.82% 58.88% +4.05%
==========================================
Files 105 105
Lines 2858 2573 -285
Branches 503 288 -215
==========================================
- Hits 1567 1515 -52
+ Misses 1030 1008 -22
+ Partials 261 50 -211 ☔ View full report in Codecov by Sentry. |
Merged
luminousleek
approved these changes
Mar 28, 2024
wait-on doesn't seem to be used at all in our workflows. Let's remove it.
In order to use tslib, we need to include this compiler option in tsconfig. Based off clean installs of angular 12 projects via ng new, this setting appears to be the default as well. See: - https://angular.io/guide/typescript-configuration#tsconfig - From https://www.npmjs.com/package/tslib
CATcher does not directly depend on node-fetch. After the removal of electron, there are no more files depending on node-fetch.
cheehongw
force-pushed
the
clean-up-deps
branch
from
45aa199
to
c2713f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Fixes #1244
Fixes #1246
Fixes #1253
Changes Made:
See discussion in summary for more details
wait-onas devDepimportHelpers: trueintsconfig.jsonas part oftslibnode-fetchas dependencyProposed Commit Message:
Instead of a squash & merge, should we do a normal merge and keep all 3 atomic commits made in this PR?